Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 12300018: Made Isolate a mandatory parameter for everything Handle-related. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed CreateCode calls. Be nicer to MIPS. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/assembler-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1094 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 __ add(esp, Immediate(kPointerSize)); 1105 __ add(esp, Immediate(kPointerSize));
1106 __ jmp(&exit); 1106 __ jmp(&exit);
1107 1107
1108 // We got a fixed array in register eax. Iterate through that. 1108 // We got a fixed array in register eax. Iterate through that.
1109 Label non_proxy; 1109 Label non_proxy;
1110 __ bind(&fixed_array); 1110 __ bind(&fixed_array);
1111 1111
1112 Handle<JSGlobalPropertyCell> cell = 1112 Handle<JSGlobalPropertyCell> cell =
1113 isolate()->factory()->NewJSGlobalPropertyCell( 1113 isolate()->factory()->NewJSGlobalPropertyCell(
1114 Handle<Object>( 1114 Handle<Object>(
1115 Smi::FromInt(TypeFeedbackCells::kForInFastCaseMarker))); 1115 Smi::FromInt(TypeFeedbackCells::kForInFastCaseMarker),
1116 isolate()));
1116 RecordTypeFeedbackCell(stmt->ForInFeedbackId(), cell); 1117 RecordTypeFeedbackCell(stmt->ForInFeedbackId(), cell);
1117 __ LoadHeapObject(ebx, cell); 1118 __ LoadHeapObject(ebx, cell);
1118 __ mov(FieldOperand(ebx, JSGlobalPropertyCell::kValueOffset), 1119 __ mov(FieldOperand(ebx, JSGlobalPropertyCell::kValueOffset),
1119 Immediate(Smi::FromInt(TypeFeedbackCells::kForInSlowCaseMarker))); 1120 Immediate(Smi::FromInt(TypeFeedbackCells::kForInSlowCaseMarker)));
1120 1121
1121 __ mov(ebx, Immediate(Smi::FromInt(1))); // Smi indicates slow check 1122 __ mov(ebx, Immediate(Smi::FromInt(1))); // Smi indicates slow check
1122 __ mov(ecx, Operand(esp, 0 * kPointerSize)); // Get enumerated object 1123 __ mov(ecx, Operand(esp, 0 * kPointerSize)); // Get enumerated object
1123 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE); 1124 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);
1124 __ CmpObjectType(ecx, LAST_JS_PROXY_TYPE, ecx); 1125 __ CmpObjectType(ecx, LAST_JS_PROXY_TYPE, ecx);
1125 __ j(above, &non_proxy); 1126 __ j(above, &non_proxy);
(...skipping 3400 matching lines...) Expand 10 before | Expand all | Expand 10 after
4526 *stack_depth = 0; 4527 *stack_depth = 0;
4527 *context_length = 0; 4528 *context_length = 0;
4528 return previous_; 4529 return previous_;
4529 } 4530 }
4530 4531
4531 #undef __ 4532 #undef __
4532 4533
4533 } } // namespace v8::internal 4534 } } // namespace v8::internal
4534 4535
4535 #endif // V8_TARGET_ARCH_IA32 4536 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698