Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: src/elements.cc

Issue 12300018: Made Isolate a mandatory parameter for everything Handle-related. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed CreateCode calls. Be nicer to MIPS. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/disassembler.cc ('k') | src/execution.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1558 matching lines...) Expand 10 before | Expand all | Expand 10 after
1569 } 1569 }
1570 SeededNumberDictionary* dictionary = 1570 SeededNumberDictionary* dictionary =
1571 SeededNumberDictionary::cast(backing_store); 1571 SeededNumberDictionary::cast(backing_store);
1572 int entry = dictionary->FindEntry(key); 1572 int entry = dictionary->FindEntry(key);
1573 if (entry != SeededNumberDictionary::kNotFound) { 1573 if (entry != SeededNumberDictionary::kNotFound) {
1574 Object* result = dictionary->DeleteProperty(entry, mode); 1574 Object* result = dictionary->DeleteProperty(entry, mode);
1575 if (result == heap->false_value()) { 1575 if (result == heap->false_value()) {
1576 if (mode == JSObject::STRICT_DELETION) { 1576 if (mode == JSObject::STRICT_DELETION) {
1577 // Deleting a non-configurable property in strict mode. 1577 // Deleting a non-configurable property in strict mode.
1578 HandleScope scope(isolate); 1578 HandleScope scope(isolate);
1579 Handle<Object> holder(obj); 1579 Handle<Object> holder(obj, isolate);
1580 Handle<Object> name = isolate->factory()->NewNumberFromUint(key); 1580 Handle<Object> name = isolate->factory()->NewNumberFromUint(key);
1581 Handle<Object> args[2] = { name, holder }; 1581 Handle<Object> args[2] = { name, holder };
1582 Handle<Object> error = 1582 Handle<Object> error =
1583 isolate->factory()->NewTypeError("strict_delete_property", 1583 isolate->factory()->NewTypeError("strict_delete_property",
1584 HandleVector(args, 2)); 1584 HandleVector(args, 2));
1585 return isolate->Throw(*error); 1585 return isolate->Throw(*error);
1586 } 1586 }
1587 return heap->false_value(); 1587 return heap->false_value();
1588 } 1588 }
1589 MaybeObject* maybe_elements = dictionary->Shrink(key); 1589 MaybeObject* maybe_elements = dictionary->Shrink(key);
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
1967 if (!maybe_obj->To(&new_backing_store)) return maybe_obj; 1967 if (!maybe_obj->To(&new_backing_store)) return maybe_obj;
1968 new_backing_store->set(0, length); 1968 new_backing_store->set(0, length);
1969 { MaybeObject* result = array->SetContent(new_backing_store); 1969 { MaybeObject* result = array->SetContent(new_backing_store);
1970 if (result->IsFailure()) return result; 1970 if (result->IsFailure()) return result;
1971 } 1971 }
1972 return array; 1972 return array;
1973 } 1973 }
1974 1974
1975 1975
1976 } } // namespace v8::internal 1976 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/disassembler.cc ('k') | src/execution.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698