Support command wrapper in make_global_settings

pylib/gyp/generator/make.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Notes:
 #
 # This is all roughly based on the Makefile system used by the Linux
 # kernel, but is a non-recursive make -- we put the entire dependency
 # graph in front of make and let it figure it out.
 #
@@ skipping 1981 matching lines @@
         'extra_commands': SHARED_HEADER_SUN_COMMANDS,
     })
   elif flavor == 'freebsd':
     header_params.update({
         'flock': 'lockf',
     })
   header_params.update(RunSystemTests(flavor))
 
   build_file, _, _ = gyp.common.ParseQualifiedTarget(target_list[0])
   make_global_settings_dict = data[build_file].get('make_global_settings', {})
+  wrappers = {}
+  wrappers['LINK'] = '%s $(builddir)/linker.lock' % flock_command
+  for key, value in make_global_settings_dict:
+    m = re.match('(.*)_wrapper', key)

[Nico, 2013/02/19 17:21:30]

if key.endswith('_wrapper'):
  wrappers[key[0:len('_wrapper')]] = ...

is a bit shorter and easier to read imho (but feel free to leave as is if you
want)

[ukai, 2013/02/20 07:22:53]

 key[0:len(key)-len('_wrapper')] ?
Done

[Nico, 2013/02/20 09:12:40]

err yes :-)

[Sam Clegg, 2013/02/20 19:55:20]

I think you can just do:

key[:-len('_wrapper')]

[ukai, 2013/02/21 06:41:44]

Done.

+    if m:
+      wrappers[m.group(1)] = '$(abspath %s)' % value
   make_global_settings = ''
   for key, value in make_global_settings_dict:
+    if re.match('.*_wrapper', key):
+      continue
     if value[0] != '$':
       value = '$(abspath %s)' % value
-    if key == 'LINK':
-      make_global_settings += ('%s ?= %s $(builddir)/linker.lock %s\n' %
-                               (key, flock_command, value))
-    elif key in ['CC', 'CXX']:
+    wrapper = wrappers.get(key)
+    if wrapper:
+      value = '%s %s' % (wrapper, value)
+      del wrappers[key]
+    if key in ['CC', 'CXX']:
       make_global_settings += (
           'ifneq (,$(filter $(origin %s), undefined default))\n' % key)
       # Let gyp-time envvars win over global settings.
       if key in os.environ:
         value = os.environ[key]
       make_global_settings += '  %s = %s\n' % (key, value)
       make_global_settings += 'endif\n'
     else:
       make_global_settings += '%s ?= %s\n' % (key, value)
+  # TODO(ukai): define cmd which wrapper only is specified in

[Nico, 2013/02/19 17:21:30]

s/which/when/
s/wrapper only/only wrapper/

[ukai, 2013/02/20 07:22:53]

Done.

+  # make_global_settings.
+
   header_params['make_global_settings'] = make_global_settings
 
   ensure_directory_exists(makefile_path)
   root_makefile = open(makefile_path, 'w')
   root_makefile.write(SHARED_HEADER % header_params)
   # Currently any versions have the same effect, but in future the behavior
   # could be different.
   if android_ndk_version:
     root_makefile.write(
         '# Define LOCAL_PATH for build of Android applications.\n'
@@ skipping 95 matching lines @@
     root_makefile.write("  include " + include_file + "\n")
     root_makefile.write("endif\n")
   root_makefile.write('\n')
 
   if generator_flags.get('auto_regeneration', True):
     WriteAutoRegenerationRule(params, root_makefile, makefile_name, build_files)
 
   root_makefile.write(SHARED_FOOTER)
 
   root_makefile.close()