Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 12300013: Make all media tests build on Win64 (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, wolenetz
Visibility:
Public.

Description

Make all media tests build on Win64 Trivial compile fixes and c4267 warning suppressions. BUG=166496 BUG=167187 BUG=176178 R=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M media/media.gyp View 4 chunks +8 lines, -0 lines 0 comments Download
M media/tools/shader_bench/window_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jschuh
PTAL. Looks like it should just be a rubberstamp.
7 years, 10 months ago (2013-02-18 15:38:13 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 10 months ago (2013-02-19 18:04:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12300013/1
7 years, 10 months ago (2013-02-19 18:05:33 UTC) #3
jschuh
7 years, 10 months ago (2013-02-20 05:01:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r183413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698