Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229983003: Trivial cleanup of copying GrPipelineBuilder (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-09 18:43:01 UTC) #2
robertphillips
Do we still need the assignment operator? https://codereview.chromium.org/1229983003/diff/1/src/gpu/GrSoftwarePathRenderer.cpp File src/gpu/GrSoftwarePathRenderer.cpp (right): https://codereview.chromium.org/1229983003/diff/1/src/gpu/GrSoftwarePathRenderer.cpp#newcode148 src/gpu/GrSoftwarePathRenderer.cpp:148: Can DrawToTargetWithPathMask ...
5 years, 5 months ago (2015-07-09 18:48:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229983003/1
5 years, 5 months ago (2015-07-09 18:52:25 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-09 18:52:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229983003/1
5 years, 5 months ago (2015-07-09 18:53:50 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 19:17:48 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4f6dc521f5082a65f42be8a333afe3bbda4ec400

Powered by Google App Engine
This is Rietveld 408576698