chrome/browser/android/download/mock_download_controller_android.cc - Issue 1229933010: move file access permission logic to DownloadResourceThrottle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/download/mock_download_controller_android.cc

Issue 1229933010: move file access permission logic to DownloadResourceThrottle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing asanka's comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/download/mock_download_controller_android.h ('k') | chrome/browser/download/chrome_download_manager_delegate_unittest.cc » ('j') | chrome/browser/download/download_request_limiter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/download/mock_download_controller_android.cc

diff --git a/chrome/browser/android/download/mock_download_controller_android.cc b/chrome/browser/android/download/mock_download_controller_android.cc

index f072e9edbbd0a05ff7ddc374d66c9f556258e482..511ca048aa7bc76ca70661abc12e6af26abdb001 100644

--- a/chrome/browser/android/download/mock_download_controller_android.cc

+++ b/chrome/browser/android/download/mock_download_controller_android.cc

@@ -38,7 +38,7 @@ void MockDownloadControllerAndroid::DangerousDownloadValidated(

}

void MockDownloadControllerAndroid::AcquireFileAccessPermission(

- content::WebContents* web_contents,

+ int render_process_id, int render_view_id,

const DownloadControllerAndroid::AcquireFileAccessPermissionCallback& cb) {

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::Bind(cb, approve_file_access_request_));