Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: chrome/browser/download/download_resource_throttle.h

Issue 1229933010: move file access permission logic to DownloadResourceThrottle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_resource_throttle.h
diff --git a/chrome/browser/download/download_resource_throttle.h b/chrome/browser/download/download_resource_throttle.h
index 4c1940f9ede18a0d7dc02d210763adff4a8053d6..4218c6aab25fdeb30c1daf4ce3fa7f58bd8eedc2 100644
--- a/chrome/browser/download/download_resource_throttle.h
+++ b/chrome/browser/download/download_resource_throttle.h
@@ -22,7 +22,28 @@ class DownloadResourceThrottle
: public content::ResourceThrottle,
public base::SupportsWeakPtr<DownloadResourceThrottle> {
public:
- DownloadResourceThrottle(DownloadRequestLimiter* limiter,
+ // Information passed between callbacks to check whether download can proceed.
+ struct DownloadRequestInfo {
+ DownloadRequestInfo(
+ scoped_refptr<DownloadRequestLimiter> limiter,
+ int render_process_id,
+ int render_view_id,
+ const GURL& url,
+ const std::string& request_method,
+ const DownloadRequestLimiter::Callback& continue_callback);
+ ~DownloadRequestInfo();
+
+ scoped_refptr<DownloadRequestLimiter> limiter;
+ int render_process_id;
+ int render_view_id;
+ GURL url;
+ std::string request_method;
+ DownloadRequestLimiter::Callback continue_callback;
+ private:
+ DISALLOW_COPY_AND_ASSIGN(DownloadRequestInfo);
+ };
+
+ DownloadResourceThrottle(scoped_refptr<DownloadRequestLimiter> limiter,
int render_process_id,
int render_view_id,
const GURL& url,
@@ -35,11 +56,12 @@ class DownloadResourceThrottle
void WillProcessResponse(bool* defer) override;
const char* GetNameForLogging() const override;
+ void ContinueDownload(bool allow);
+
private:
~DownloadResourceThrottle() override;
void WillDownload(bool* defer);
- void ContinueDownload(bool allow);
// Set to true when we are querying the DownloadRequestLimiter.
bool querying_limiter_;
« no previous file with comments | « chrome/browser/download/download_request_limiter.cc ('k') | chrome/browser/download/download_resource_throttle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698