content/browser/android/download_controller_android_impl.h - Issue 1229933010: move file access permission logic to DownloadResourceThrottle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/download_controller_android_impl.h

Issue 1229933010: move file access permission logic to DownloadResourceThrottle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/chrome_tests_unit.gypi ('K') | « chrome/chrome_tests_unit.gypi ('k') | content/browser/android/download_controller_android_impl.cc » ('j') | content/browser/android/download_controller_android_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/download_controller_android_impl.h

diff --git a/content/browser/android/download_controller_android_impl.h b/content/browser/android/download_controller_android_impl.h

index 2363d46d34a2c406bb71e812f6cfd3603c03cd57..55cfc6a36f081d840c482f5afc309d5bc8e2506e 100644

--- a/content/browser/android/download_controller_android_impl.h

+++ b/content/browser/android/download_controller_android_impl.h

@@ -56,7 +56,7 @@ class DownloadControllerAndroidImpl : public DownloadControllerAndroid,

// DownloadControllerAndroid implementation.

void AcquireFileAccessPermission(

- WebContents* web_contents,

+ int render_process_id, int render_view_id,

const AcquireFileAccessPermissionCallback& callback) override;

private:

@@ -136,8 +136,6 @@ class DownloadControllerAndroidImpl : public DownloadControllerAndroid,

base::android::ScopedJavaLocalRef<jobject> GetContentViewCoreFromWebContents(

WebContents* web_contents);

- WebContents* GetWebContents(int render_process_id, int render_view_id);

// Creates Java object if it is not created already and returns it.

JavaObject* GetJavaObject();