chrome/browser/download/download_resource_throttle.h - Issue 1229933010: move file access permission logic to DownloadResourceThrottle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_resource_throttle.h

Issue 1229933010: move file access permission logic to DownloadResourceThrottle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/chrome_download_manager_delegate_unittest.cc ('k') | chrome/browser/download/download_resource_throttle.cc » ('j') | chrome/browser/download/download_resource_throttle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_resource_throttle.h

diff --git a/chrome/browser/download/download_resource_throttle.h b/chrome/browser/download/download_resource_throttle.h

index 4c1940f9ede18a0d7dc02d210763adff4a8053d6..45d7ab501f8b1fa4f6bcadaf32af02c05258eb74 100644

--- a/chrome/browser/download/download_resource_throttle.h

+++ b/chrome/browser/download/download_resource_throttle.h

@@ -22,7 +22,7 @@ class DownloadResourceThrottle

: public content::ResourceThrottle,

public base::SupportsWeakPtr<DownloadResourceThrottle> {

public:

- DownloadResourceThrottle(DownloadRequestLimiter* limiter,

+ DownloadResourceThrottle(scoped_refptr<DownloadRequestLimiter> limiter,

int render_process_id,

int render_view_id,

const GURL& url,

@@ -38,6 +38,13 @@ class DownloadResourceThrottle

private:

~DownloadResourceThrottle() override;

+ void FileAccessPermissionGranted(

+ scoped_refptr<DownloadRequestLimiter> limiter,

+ int render_process_id,

+ int render_view_id,

+ const GURL& url,

+ const std::string& request_method,

+ bool granted);

void WillDownload(bool* defer);

void ContinueDownload(bool allow);