move file access permission logic to DownloadResourceThrottle

content/browser/android/download_controller_android_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/download_controller_android_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 25 matching lines @@
 #include "net/http/http_response_headers.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 
 using base::android::ConvertUTF8ToJavaString;
 using base::android::ScopedJavaLocalRef;
 
 namespace {
 // Guards download_controller_
 base::LazyInstance<base::Lock> g_download_controller_lock_;
+
+content::WebContents* GetWebContents(
+    int render_process_id, int render_view_id) {
+  content::RenderViewHost* render_view_host =
+      content::RenderViewHost::FromID(render_process_id, render_view_id);
+
+  if (!render_view_host)
+    return NULL;

[asanka, 2015/07/13 19:13:42]

nullptr

[qinmin, 2015/07/14 00:30:57]

Done.

+
+  return render_view_host->GetDelegate()->GetAsWebContents();

[asanka, 2015/07/13 19:13:42]

WebContents::FromRenderViewHost()

It does basically the same thing, but we should use use it instead.

[qinmin, 2015/07/14 00:30:57]

Done.

 }
 
+void CreateContextMenuDownload(
+    int render_process_id, int render_view_id,
+    const content::ContextMenuParams& params, bool is_link,
+    const std::string& extra_headers, bool granted) {
+  if (!granted)
+    return;
+
+  content::WebContents* web_contents =
+      GetWebContents(render_process_id, render_view_id);
+  if (!web_contents)
+    return;
+
+  const GURL& url = is_link ? params.link_url : params.src_url;
+  const GURL& referring_url = params.frame_url.is_empty() ?
+      params.page_url : params.frame_url;
+  content::DownloadManagerImpl* dlm =
+      static_cast<content::DownloadManagerImpl*>(
+          content::BrowserContext::GetDownloadManager(
+              web_contents->GetBrowserContext()));
+  scoped_ptr<content::DownloadUrlParameters> dl_params(
+      content::DownloadUrlParameters::FromWebContents(web_contents, url));
+  content::Referrer referrer = content::Referrer::SanitizeForRequest(
+      url,
+      content::Referrer(referring_url.GetAsReferrer(),
+                        params.referrer_policy));
+  dl_params->set_referrer(referrer);
+  if (is_link)
+    dl_params->set_referrer_encoding(params.frame_charset);
+  net::HttpRequestHeaders headers;
+  headers.AddHeadersFromString(extra_headers);
+  for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext();)
+    dl_params->add_request_header(it.name(), it.value());
+  if (!is_link && extra_headers.empty())
+    dl_params->set_prefer_cache(true);
+  dl_params->set_prompt(false);
+  dlm->DownloadUrl(dl_params.Pass());
+}
+
+}  // namespace
+
 namespace content {
 
 // JNI methods
 static void Init(JNIEnv* env, jobject obj) {
   DownloadControllerAndroidImpl::GetInstance()->Init(env, obj);
 }
 
 static void OnRequestFileAccessResult(
     JNIEnv* env, jobject obj, jlong callback_id, jboolean granted) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ skipping 63 matching lines @@
   for (auto iter = deferred_downloads_.begin();
       iter != deferred_downloads_.end(); ++iter) {
     if (*iter == observer) {
       deferred_downloads_.erase(iter);
       return;
     }
   }
 }
 
 void DownloadControllerAndroidImpl::AcquireFileAccessPermission(
-    WebContents* web_contents,
+    int render_process_id, int render_view_id,
     const DownloadControllerAndroid::AcquireFileAccessPermissionCallback& cb) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
+  WebContents* web_contents = GetWebContents(render_process_id, render_view_id);
   if (!web_contents) {
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE, base::Bind(cb, false));
     return;
   }
 
   ScopedJavaLocalRef<jobject> view =
       GetContentViewCoreFromWebContents(web_contents);
   if (view.is_null()) {
     BrowserThread::PostTask(
@@ skipping 154 matching lines @@
     // ContentViewCore is created.
     deferred_downloads_.push_back(new DeferredDownloadObserver(
         web_contents,
         base::Bind(&DownloadControllerAndroidImpl::StartAndroidDownload,
                    base::Unretained(this), render_process_id, render_view_id,
                    info)));
     return;
   }
 
   AcquireFileAccessPermission(
-      web_contents,
+      render_process_id, render_view_id,
       base::Bind(&DownloadControllerAndroidImpl::StartAndroidDownloadInternal,
                  base::Unretained(this), render_process_id, render_view_id,
                  info));
 }
 
 void DownloadControllerAndroidImpl::StartAndroidDownloadInternal(
     int render_process_id, int render_view_id,
     const DownloadInfoAndroid& info, bool allowed) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   if (!allowed)
@@ skipping 123 matching lines @@
       env, item->GetTargetFilePath().BaseName().value());
   ScopedJavaLocalRef<jobject> view_core = GetContentViewCoreFromWebContents(
       item->GetWebContents());
   if (!view_core.is_null()) {
     Java_DownloadController_onDangerousDownload(
         env, GetJavaObject()->Controller(env).obj(), view_core.obj(),
         jfilename.obj(), item->GetId());
   }
 }
 
-WebContents* DownloadControllerAndroidImpl::GetWebContents(
-    int render_process_id, int render_view_id) {
-  RenderViewHost* render_view_host =
-      RenderViewHost::FromID(render_process_id, render_view_id);
-
-  if (!render_view_host)
-    return NULL;
-
-  return render_view_host->GetDelegate()->GetAsWebContents();
-}
-
 ScopedJavaLocalRef<jobject>
     DownloadControllerAndroidImpl::GetContentViewCoreFromWebContents(
     WebContents* web_contents) {
   if (!web_contents)
     return ScopedJavaLocalRef<jobject>();
 
   ContentViewCore* view_core = ContentViewCore::FromWebContents(web_contents);
   return view_core ? view_core->GetJavaObject() :
       ScopedJavaLocalRef<jobject>();
 }
 
 DownloadControllerAndroidImpl::JavaObject*
     DownloadControllerAndroidImpl::GetJavaObject() {
   if (!java_object_) {
     // Initialize Java DownloadController by calling
     // DownloadController.getInstance(), which will call Init()
     // if Java DownloadController is not instantiated already.
     JNIEnv* env = base::android::AttachCurrentThread();
     Java_DownloadController_getInstance(env);
   }
 
   DCHECK(java_object_);
   return java_object_;
 }
 
 void DownloadControllerAndroidImpl::StartContextMenuDownload(
     const ContextMenuParams& params, WebContents* web_contents, bool is_link,
     const std::string& extra_headers) {
-  const GURL& url = is_link ? params.link_url : params.src_url;
-  const GURL& referring_url = params.frame_url.is_empty() ?
-      params.page_url : params.frame_url;
-  DownloadManagerImpl* dlm = static_cast<DownloadManagerImpl*>(
-      BrowserContext::GetDownloadManager(web_contents->GetBrowserContext()));
-  scoped_ptr<DownloadUrlParameters> dl_params(
-      DownloadUrlParameters::FromWebContents(web_contents, url));
-  content::Referrer referrer = content::Referrer::SanitizeForRequest(
-      url,
-      content::Referrer(referring_url.GetAsReferrer(),
-                        params.referrer_policy));
-  dl_params->set_referrer(referrer);
-  if (is_link)
-    dl_params->set_referrer_encoding(params.frame_charset);
-  net::HttpRequestHeaders headers;
-  headers.AddHeadersFromString(extra_headers);
-  for (net::HttpRequestHeaders::Iterator it(headers); it.GetNext();)
-    dl_params->add_request_header(it.name(), it.value());
-  if (!is_link && extra_headers.empty())
-    dl_params->set_prefer_cache(true);
-  dl_params->set_prompt(false);
-  dlm->DownloadUrl(dl_params.Pass());
+  int process_id = web_contents->GetRenderProcessHost()->GetID();
+  int routing_id = web_contents->GetRoutingID();
+  AcquireFileAccessPermission(
+      process_id, routing_id, base::Bind(
+          &CreateContextMenuDownload, process_id, routing_id, params, is_link,
+          extra_headers));
 }
 
 void DownloadControllerAndroidImpl::DangerousDownloadValidated(
     WebContents* web_contents, int download_id, bool accept) {
   if (!web_contents)
     return;
   DownloadManagerImpl* dlm = static_cast<DownloadManagerImpl*>(
       BrowserContext::GetDownloadManager(web_contents->GetBrowserContext()));
   DownloadItem* item = dlm->GetDownload(download_id);
   if (!item)
@@ skipping 17 matching lines @@
   if (user_agent.empty())
     user_agent = GetContentClient()->GetUserAgent();
   GURL referer_url(request->referrer());
   if (referer_url.is_valid())
     referer = referer_url.spec();
   if (!request->url_chain().empty()) {
     original_url = request->url_chain().front();
     url = request->url_chain().back();
   }
 
-  const content::ResourceRequestInfo* info =
-      content::ResourceRequestInfo::ForRequest(request);
+  const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);
   if (info)
     has_user_gesture = info->HasUserGesture();
 }
 
 DownloadControllerAndroidImpl::DownloadInfoAndroid::~DownloadInfoAndroid() {}
 
 }  // namespace content