Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1229933007: Make quota logic obey durable storage permission (Closed)

Created:
5 years, 5 months ago by dgrogan
Modified:
5 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@3_top_durable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make quota logic obey durable storage permission When the quota database is asked for the least recently used origin for eviction it should not return any origins that have been granted the durable storage permission. Note that there is no easy way for a user to set this permission yet. That is coming in https://codereview.chromium.org/1164073005/ and https://codereview.chromium.org/1154573005/ BUG=482814 Committed: https://crrev.com/5f7b6c265895c0021af511ce73a1241b407395dd Cr-Commit-Position: refs/heads/master@{#339783}

Patch Set 1 #

Patch Set 2 : better permission retrieval and unit test #

Patch Set 3 : Added unit test for LRU eviction #

Patch Set 4 : fix extensions_browsertests compile #

Messages

Total messages: 18 (8 generated)
dgrogan
Hello, could you review the portions of this CL listed below? The content_settings is what ...
5 years, 5 months ago (2015-07-16 01:26:48 UTC) #3
jochen (gone - plz use gerrit)
+markusheintz for content settings content/ and plumbing the stuff through the special storage policy lgtm
5 years, 5 months ago (2015-07-16 10:49:20 UTC) #5
not at google - send to devlin
extensions lgtm
5 years, 5 months ago (2015-07-16 16:07:48 UTC) #6
michaeln
lgtm 2
5 years, 5 months ago (2015-07-16 23:09:18 UTC) #7
markusheintz_
On 2015/07/16 23:09:18, michaeln wrote: > lgtm 2 LGTM
5 years, 5 months ago (2015-07-21 07:51:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229933007/60001
5 years, 5 months ago (2015-07-21 21:02:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/75899) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-21 21:16:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229933007/100001
5 years, 5 months ago (2015-07-21 21:56:03 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 5 months ago (2015-07-21 23:43:14 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 23:45:10 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5f7b6c265895c0021af511ce73a1241b407395dd
Cr-Commit-Position: refs/heads/master@{#339783}

Powered by Google App Engine
This is Rietveld 408576698