WebUI: Convert History to use new HTML Import style for JavaScript.

WebUI: Convert History to use new HTML Import style for JavaScript.

BUG=425625
Committed: https://crrev.com/3244892cb3b02790d7c7c74ac5d73e6bdb722a10
Cr-Commit-Position: refs/heads/master@{#338195}

[tommycli, 2015-07-09 21:50:42]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2015-07-09 21:50:42]

dbeam: Whew. Let me know if this is what you were thinking of.

Tommy

[Dan Beam, 2015-07-09 22:02:57]

lgtm

eventually I want all scripts to have their dependencies self-contained so
including cr/ui/overlay.html would pull in cr.html and cr/ui.html etc.

we'll get there

https://codereview.chromium.org/1229933006/diff/20001/chrome/browser/resource...
File chrome/browser/resources/history/history.html (right):

https://codereview.chromium.org/1229933006/diff/20001/chrome/browser/resource...
chrome/browser/resources/history/history.html:39:
href="chrome://resources/html/cr/ui/focus_outline_manager.html">
just keep these on the same line, e.g.

  <link rel="import"
href="chrome://resources/html/cr/ui/focus_outline_manager.html">

even if it's over 80 chars

https://codereview.chromium.org/1229933006/diff/20001/ui/webui/resources/html...
File ui/webui/resources/html/action_link.html (right):

https://codereview.chromium.org/1229933006/diff/20001/ui/webui/resources/html...
ui/webui/resources/html/action_link.html:1: <!-- Allows importing via HTML
imports to avoid duplicating this resource. -->
just delete these comments, IMO

[tommycli, 2015-07-09 22:20:26]

dbeam: sounds good to me!

https://codereview.chromium.org/1229933006/diff/20001/chrome/browser/resource...
File chrome/browser/resources/history/history.html (right):

https://codereview.chromium.org/1229933006/diff/20001/chrome/browser/resource...
chrome/browser/resources/history/history.html:39:
href="chrome://resources/html/cr/ui/focus_outline_manager.html">
On 2015/07/09 22:02:57, Dan Beam wrote:
> just keep these on the same line, e.g.
> 
>   <link rel="import"
> href="chrome://resources/html/cr/ui/focus_outline_manager.html">
> 
> even if it's over 80 chars

Done.

https://codereview.chromium.org/1229933006/diff/20001/ui/webui/resources/html...
File ui/webui/resources/html/action_link.html (right):

https://codereview.chromium.org/1229933006/diff/20001/ui/webui/resources/html...
ui/webui/resources/html/action_link.html:1: <!-- Allows importing via HTML
imports to avoid duplicating this resource. -->
On 2015/07/09 22:02:57, Dan Beam wrote:
> just delete these comments, IMO

Done.

[tommycli, 2015-07-09 22:45:43]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2015-07-09 22:45:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1229933006/#ps50001
(title: " ")

[commit-bot: I haz the power, 2015-07-09 22:46:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229933006/50001

[commit-bot: I haz the power, 2015-07-09 23:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 23:52:08]

Dry run: This issue passed the CQ dry run.

[tommycli, 2015-07-10 00:17:06]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2015-07-10 00:18:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229933006/50001

[commit-bot: I haz the power, 2015-07-10 00:24:53]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2015-07-10 00:25:54]

Patchset 4 (id:??) landed as
https://crrev.com/3244892cb3b02790d7c7c74ac5d73e6bdb722a10
Cr-Commit-Position: refs/heads/master@{#338195}