Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229933005: Revert "Componentize chrome/browser/rlz" (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, Matt Giuca, oshima+watch_chromium.org, stevenjb+watch_chromium.org, tapted, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Componentize chrome/browser/rlz" This reverts commit 311a46585ee5b77486ef42d947bc7cc7566558b1 / #338040, https://codereview.chromium.org/1212163011/. The change broke tests in official builds (http://crbug.com/508659). BUG=504841, 508148, 508659 TBR=sdefresne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/66706d26418b305f48c7124039a804a7c826a463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -2982 lines) Patch
M build/common.gypi View 2 chunks +3 lines, -10 lines 0 comments Download
M build/config/features.gni View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 4 chunks +7 lines, -14 lines 0 comments Download
D chrome/browser/rlz/chrome_rlz_tracker_delegate.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/rlz/chrome_rlz_tracker_delegate.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D chrome/browser/rlz/chrome_rlz_tracker_delegate_unittest.cc View 1 chunk +0 lines, -48 lines 0 comments Download
A + chrome/browser/rlz/rlz.h View 8 chunks +39 lines, -35 lines 0 comments Download
A + chrome/browser/rlz/rlz.cc View 20 chunks +222 lines, -81 lines 0 comments Download
A + chrome/browser/rlz/rlz_chromeos.cc View 2 chunks +1 line, -5 lines 0 comments Download
A chrome/browser/rlz/rlz_ios.mm View 1 chunk +14 lines, -0 lines 0 comments Download
A + chrome/browser/rlz/rlz_mac.cc View 2 chunks +1 line, -5 lines 0 comments Download
A + chrome/browser/rlz/rlz_unittest.cc View 34 chunks +206 lines, -290 lines 0 comments Download
A + chrome/browser/rlz/rlz_win.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/search_engines/ui_thread_search_terms_data.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +8 lines, -22 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +4 lines, -7 lines 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +0 lines, -20 lines 0 comments Download
D components/rlz.gypi View 1 chunk +0 lines, -38 lines 0 comments Download
D components/rlz/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D components/rlz/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D components/rlz/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/rlz/rlz_tracker.h View 1 chunk +0 lines, -242 lines 0 comments Download
D components/rlz/rlz_tracker.cc View 1 chunk +0 lines, -529 lines 0 comments Download
D components/rlz/rlz_tracker_chromeos.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D components/rlz/rlz_tracker_delegate.h View 1 chunk +0 lines, -86 lines 0 comments Download
D components/rlz/rlz_tracker_delegate.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D components/rlz/rlz_tracker_ios.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D components/rlz/rlz_tracker_mac.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D components/rlz/rlz_tracker_unittest.cc View 1 chunk +0 lines, -1009 lines 0 comments Download
D components/rlz/rlz_tracker_win.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M rlz/test/rlz_test_helpers.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
5 years, 5 months ago (2015-07-09 21:18:53 UTC) #1
Nico
Committed patchset #1 (id:1) manually as 66706d26418b305f48c7124039a804a7c826a463 (presubmit successful).
5 years, 5 months ago (2015-07-09 21:21:59 UTC) #2
sdefresne
5 years, 5 months ago (2015-07-10 08:15:37 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698