Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: Source/core/loader/FrameLoadRequest.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use AtomicString type for frameName and target Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/FormSubmission.cpp ('k') | Source/core/loader/FrameLoaderClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameLoadRequest.h
diff --git a/Source/core/loader/FrameLoadRequest.h b/Source/core/loader/FrameLoadRequest.h
index 5f854f83f6a67e5845e407ac798c6ddef67c6626..09d992a26500a960272c9f0969e6174c428f6d93 100644
--- a/Source/core/loader/FrameLoadRequest.h
+++ b/Source/core/loader/FrameLoadRequest.h
@@ -55,7 +55,7 @@ public:
{
}
- FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const String& frameName)
+ FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const AtomicString& frameName)
: m_originDocument(originDocument)
, m_resourceRequest(resourceRequest)
, m_frameName(frameName)
@@ -80,8 +80,8 @@ public:
ResourceRequest& resourceRequest() { return m_resourceRequest; }
const ResourceRequest& resourceRequest() const { return m_resourceRequest; }
- const String& frameName() const { return m_frameName; }
- void setFrameName(const String& frameName) { m_frameName = frameName; }
+ const AtomicString& frameName() const { return m_frameName; }
+ void setFrameName(const AtomicString& frameName) { m_frameName = frameName; }
const SubstituteData& substituteData() const { return m_substituteData; }
@@ -103,7 +103,7 @@ public:
private:
RefPtr<Document> m_originDocument;
ResourceRequest m_resourceRequest;
- String m_frameName;
+ AtomicString m_frameName;
SubstituteData m_substituteData;
bool m_lockBackForwardList;
ClientRedirectPolicy m_clientRedirect;
« no previous file with comments | « Source/core/loader/FormSubmission.cpp ('k') | Source/core/loader/FrameLoaderClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698