Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: Source/core/loader/FormSubmission.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use AtomicString type for frameName and target Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/EmptyClients.cpp ('k') | Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FormSubmission.h
diff --git a/Source/core/loader/FormSubmission.h b/Source/core/loader/FormSubmission.h
index d53b2e686ecd8bde7d7b3038dc413e061cf21d2d..2d56480b2a2c1c9ba531c9fdc4d863fc9217fd15 100644
--- a/Source/core/loader/FormSubmission.h
+++ b/Source/core/loader/FormSubmission.h
@@ -68,8 +68,8 @@ public:
const String& action() const { return m_action; }
void parseAction(const String&);
- const String& target() const { return m_target; }
- void setTarget(const String& target) { m_target = target; }
+ const AtomicString& target() const { return m_target; }
+ void setTarget(const AtomicString& target) { m_target = target; }
const String& encodingType() const { return m_encodingType; }
static String parseEncodingType(const String&);
@@ -86,7 +86,7 @@ public:
bool m_isMultiPartForm;
String m_action;
- String m_target;
+ AtomicString m_target;
String m_encodingType;
String m_acceptCharset;
};
@@ -99,8 +99,8 @@ public:
Method method() const { return m_method; }
const KURL& action() const { return m_action; }
- const String& target() const { return m_target; }
- void clearTarget() { m_target = String(); }
+ const AtomicString& target() const { return m_target; }
+ void clearTarget() { m_target = nullAtom; }
const String& contentType() const { return m_contentType; }
FormState* state() const { return m_formState.get(); }
FormData* data() const { return m_formData.get(); }
@@ -115,14 +115,14 @@ public:
const String& result() const { return m_result; }
private:
- FormSubmission(Method, const KURL& action, const String& target, const String& contentType, PassRefPtr<FormState>, PassRefPtr<FormData>, const String& boundary, PassRefPtr<Event>);
+ FormSubmission(Method, const KURL& action, const AtomicString& target, const String& contentType, PassRefPtr<FormState>, PassRefPtr<FormData>, const String& boundary, PassRefPtr<Event>);
// FormSubmission for DialogMethod
FormSubmission(const String& result);
// FIXME: Hold an instance of Attributes instead of individual members.
Method m_method;
KURL m_action;
- String m_target;
+ AtomicString m_target;
String m_contentType;
RefPtr<FormState> m_formState;
RefPtr<FormData> m_formData;
« no previous file with comments | « Source/core/loader/EmptyClients.cpp ('k') | Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698