Source/core/dom/Element.h - Issue 122993002: Make calls to AtomicString(const String&) explicit in web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString type for frameName and target Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.h

diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h

index 93c19895bae3aec6e8c7252425e8308a139affc4..fad133ebdc13f1df534f4fef79dc50275beb1056 100644

--- a/Source/core/dom/Element.h

+++ b/Source/core/dom/Element.h

@@ -375,7 +375,7 @@ public:

KURL getNonEmptyURLAttribute(const QualifiedName&) const;

virtual const AtomicString imageSourceURL() const;

- virtual String target() const { return String(); }

+ virtual AtomicString target() const { return nullAtom; }

virtual Image* imageContents() { return 0; }

virtual void focus(bool restorePreviousSelection = true, FocusDirection = FocusDirectionNone);

« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/html/HTMLAnchorElement.h » ('j') | no next file with comments »