Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: Source/web/FrameLoaderClientImpl.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use AtomicString type for frameName and target Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 virtual void didDisplayInsecureContent(); 105 virtual void didDisplayInsecureContent();
106 virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore:: KURL& insecureURL); 106 virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore:: KURL& insecureURL);
107 virtual void didDetectXSS(const WebCore::KURL&, bool didBlockEntirePage); 107 virtual void didDetectXSS(const WebCore::KURL&, bool didBlockEntirePage);
108 virtual void didDispatchPingLoader(const WebCore::KURL&); 108 virtual void didDispatchPingLoader(const WebCore::KURL&);
109 virtual void selectorMatchChanged(const Vector<String>& addedSelectors, cons t Vector<String>& removedSelectors); 109 virtual void selectorMatchChanged(const Vector<String>& addedSelectors, cons t Vector<String>& removedSelectors);
110 virtual PassRefPtr<WebCore::DocumentLoader> createDocumentLoader( 110 virtual PassRefPtr<WebCore::DocumentLoader> createDocumentLoader(
111 const WebCore::ResourceRequest&, const WebCore::SubstituteData&); 111 const WebCore::ResourceRequest&, const WebCore::SubstituteData&);
112 virtual WTF::String userAgent(const WebCore::KURL&); 112 virtual WTF::String userAgent(const WebCore::KURL&);
113 virtual WTF::String doNotTrackValue(); 113 virtual WTF::String doNotTrackValue();
114 virtual void transitionToCommittedForNewPage(); 114 virtual void transitionToCommittedForNewPage();
115 virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL&, const W TF::String& name, const WTF::String& referrer, WebCore::HTMLFrameOwnerElement*); 115 virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL&, const W TF::AtomicString& name, const WTF::String& referrer, WebCore::HTMLFrameOwnerElem ent*);
116 virtual PassRefPtr<WebCore::Widget> createPlugin( 116 virtual PassRefPtr<WebCore::Widget> createPlugin(
117 const WebCore::IntSize&, WebCore::HTMLPlugInElement*, const WebCore::KUR L&, 117 const WebCore::IntSize&, WebCore::HTMLPlugInElement*, const WebCore::KUR L&,
118 const Vector<WTF::String>&, const Vector<WTF::String>&, 118 const Vector<WTF::String>&, const Vector<WTF::String>&,
119 const WTF::String&, bool loadManually); 119 const WTF::String&, bool loadManually);
120 virtual PassRefPtr<WebCore::Widget> createJavaAppletWidget( 120 virtual PassRefPtr<WebCore::Widget> createJavaAppletWidget(
121 const WebCore::IntSize&, 121 const WebCore::IntSize&,
122 WebCore::HTMLAppletElement*, 122 WebCore::HTMLAppletElement*,
123 const WebCore::KURL& /* base_url */, 123 const WebCore::KURL& /* base_url */,
124 const Vector<WTF::String>& paramNames, 124 const Vector<WTF::String>& paramNames,
125 const Vector<WTF::String>& paramValues); 125 const Vector<WTF::String>& paramValues);
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 // The WebFrame that owns this object and manages its lifetime. Therefore, 164 // The WebFrame that owns this object and manages its lifetime. Therefore,
165 // the web frame object is guaranteed to exist. 165 // the web frame object is guaranteed to exist.
166 WebFrameImpl* m_webFrame; 166 WebFrameImpl* m_webFrame;
167 }; 167 };
168 168
169 DEFINE_TYPE_CASTS(FrameLoaderClientImpl, WebCore::FrameLoaderClient, client, cli ent->isFrameLoaderClientImpl(), client.isFrameLoaderClientImpl()); 169 DEFINE_TYPE_CASTS(FrameLoaderClientImpl, WebCore::FrameLoaderClient, client, cli ent->isFrameLoaderClientImpl(), client.isFrameLoaderClientImpl());
170 170
171 } // namespace blink 171 } // namespace blink
172 172
173 #endif 173 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698