Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: Source/core/html/HTMLBaseElement.cpp

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use AtomicString type for frameName and target Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLBaseElement.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2008, 2009, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2008, 2009, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 HTMLElement::removedFrom(insertionPoint); 65 HTMLElement::removedFrom(insertionPoint);
66 if (insertionPoint->inDocument()) 66 if (insertionPoint->inDocument())
67 document().processBaseElement(); 67 document().processBaseElement();
68 } 68 }
69 69
70 bool HTMLBaseElement::isURLAttribute(const Attribute& attribute) const 70 bool HTMLBaseElement::isURLAttribute(const Attribute& attribute) const
71 { 71 {
72 return attribute.name().localName() == hrefAttr || HTMLElement::isURLAttribu te(attribute); 72 return attribute.name().localName() == hrefAttr || HTMLElement::isURLAttribu te(attribute);
73 } 73 }
74 74
75 String HTMLBaseElement::target() const 75 AtomicString HTMLBaseElement::target() const
76 { 76 {
77 return fastGetAttribute(targetAttr); 77 return fastGetAttribute(targetAttr);
78 } 78 }
79 79
80 KURL HTMLBaseElement::href() const 80 KURL HTMLBaseElement::href() const
81 { 81 {
82 // This does not use the getURLAttribute function because that will resolve relative to the document's base URL; 82 // This does not use the getURLAttribute function because that will resolve relative to the document's base URL;
83 // base elements like this one can be used to set that base URL. Thus we nee d to resolve relative to the document's 83 // base elements like this one can be used to set that base URL. Thus we nee d to resolve relative to the document's
84 // URL and ignore the base URL. 84 // URL and ignore the base URL.
85 85
(...skipping 10 matching lines...) Expand all
96 96
97 return url; 97 return url;
98 } 98 }
99 99
100 void HTMLBaseElement::setHref(const AtomicString& value) 100 void HTMLBaseElement::setHref(const AtomicString& value)
101 { 101 {
102 setAttribute(hrefAttr, value); 102 setAttribute(hrefAttr, value);
103 } 103 }
104 104
105 } 105 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLBaseElement.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698