Source/core/html/HTMLAreaElement.cpp - Issue 122993002: Make calls to AtomicString(const String&) explicit in web/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLAreaElement.cpp

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString type for frameName and target Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2004, 2005, 2006, 2009, 2011 Apple Inc. All rights reserved.	4 * Copyright (C) 2004, 2005, 2006, 2009, 2011 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 228 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
239 imageElement->updateFocusAppearance(restorePreviousSelection);	239 imageElement->updateFocusAppearance(restorePreviousSelection);

240 }	240 }

241	241

242 bool HTMLAreaElement::supportsFocus() const	242 bool HTMLAreaElement::supportsFocus() const

243 {	243 {

244 // If the AREA element was a link, it should support focus.	244 // If the AREA element was a link, it should support focus.

245 // FIXME: This means that an AREA that is not a link cannot be made focusabl e through contenteditable or tabindex. Is it correct?	245 // FIXME: This means that an AREA that is not a link cannot be made focusabl e through contenteditable or tabindex. Is it correct?

246 return isLink();	246 return isLink();

247 }	247 }

248	248

249 String HTMLAreaElement::target() const	249 AtomicString HTMLAreaElement::target() const

250 {	250 {

251 return getAttribute(targetAttr);	251 return getAttribute(targetAttr);

252 }	252 }

253	253

254 }	254 }

OLD	NEW

« no previous file with comments | « Source/core/html/HTMLAreaElement.h ('k') | Source/core/html/HTMLBaseElement.h » ('j') | no next file with comments »