Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: Source/core/dom/Document.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use AtomicString type for frameName and target Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/dom/Element.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 531
532 const KURL& url() const { return m_url; } 532 const KURL& url() const { return m_url; }
533 void setURL(const KURL&); 533 void setURL(const KURL&);
534 534
535 // To understand how these concepts relate to one another, please see the 535 // To understand how these concepts relate to one another, please see the
536 // comments surrounding their declaration. 536 // comments surrounding their declaration.
537 const KURL& baseURL() const { return m_baseURL; } 537 const KURL& baseURL() const { return m_baseURL; }
538 void setBaseURLOverride(const KURL&); 538 void setBaseURLOverride(const KURL&);
539 const KURL& baseURLOverride() const { return m_baseURLOverride; } 539 const KURL& baseURLOverride() const { return m_baseURLOverride; }
540 const KURL& baseElementURL() const { return m_baseElementURL; } 540 const KURL& baseElementURL() const { return m_baseElementURL; }
541 const String& baseTarget() const { return m_baseTarget; } 541 const AtomicString& baseTarget() const { return m_baseTarget; }
542 void processBaseElement(); 542 void processBaseElement();
543 543
544 KURL completeURL(const String&) const; 544 KURL completeURL(const String&) const;
545 KURL completeURL(const String&, const KURL& baseURLOverride) const; 545 KURL completeURL(const String&, const KURL& baseURLOverride) const;
546 546
547 virtual String userAgent(const KURL&) const; 547 virtual String userAgent(const KURL&) const;
548 virtual void disableEval(const String& errorMessage); 548 virtual void disableEval(const String& errorMessage);
549 549
550 bool canNavigate(Frame* targetFrame); 550 bool canNavigate(Frame* targetFrame);
551 Frame* findUnsafeParentScrollPropagationBoundary(); 551 Frame* findUnsafeParentScrollPropagationBoundary();
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
1125 KURL m_baseElementURL; // The URL set by the <base> element. 1125 KURL m_baseElementURL; // The URL set by the <base> element.
1126 KURL m_cookieURL; // The URL to use for cookie access. 1126 KURL m_cookieURL; // The URL to use for cookie access.
1127 1127
1128 // Document.documentURI: 1128 // Document.documentURI:
1129 // Although URL-like, Document.documentURI can actually be set to any 1129 // Although URL-like, Document.documentURI can actually be set to any
1130 // string by content. Document.documentURI affects m_baseURL unless the 1130 // string by content. Document.documentURI affects m_baseURL unless the
1131 // document contains a <base> element, in which case the <base> element 1131 // document contains a <base> element, in which case the <base> element
1132 // takes precedence. 1132 // takes precedence.
1133 String m_documentURI; 1133 String m_documentURI;
1134 1134
1135 String m_baseTarget; 1135 AtomicString m_baseTarget;
1136 1136
1137 RefPtr<DocumentType> m_docType; 1137 RefPtr<DocumentType> m_docType;
1138 OwnPtr<DOMImplementation> m_implementation; 1138 OwnPtr<DOMImplementation> m_implementation;
1139 1139
1140 RefPtr<CSSStyleSheet> m_elemSheet; 1140 RefPtr<CSSStyleSheet> m_elemSheet;
1141 1141
1142 bool m_printing; 1142 bool m_printing;
1143 bool m_paginatedForScreen; 1143 bool m_paginatedForScreen;
1144 1144
1145 CompatibilityMode m_compatibilityMode; 1145 CompatibilityMode m_compatibilityMode;
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
1354 inline bool Node::isDocumentNode() const 1354 inline bool Node::isDocumentNode() const
1355 { 1355 {
1356 return this == documentInternal(); 1356 return this == documentInternal();
1357 } 1357 }
1358 1358
1359 Node* eventTargetNodeForDocument(Document*); 1359 Node* eventTargetNodeForDocument(Document*);
1360 1360
1361 } // namespace WebCore 1361 } // namespace WebCore
1362 1362
1363 #endif // Document_h 1363 #endif // Document_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698