dart2js: support tear-offs in the startup emitter.

dart2js: support tear-offs in the startup emitter.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/62b49eadc62c6ed9e783298f23e14881d52a41fa

[floitsch, 2015-07-10 18:35:10]

floitsch@google.com changed reviewers:
+ herhut@google.com

[floitsch, 2015-07-13 16:11:20]

If you already looked at this CL, PTAL.
I added a fix for deferred tear-offs.

[floitsch, 2015-07-22 15:06:59]

If you already looked at this CL, PTAL.
I added a fix for static functions (which could clash in minified mode).

[floitsch, 2015-07-22 15:07:31]

floitsch@google.com changed reviewers:
+ sigmund@google.com

[floitsch, 2015-07-22 15:07:32]

adding Siggi as reviewer.

[Siggi Cherem (dart-lang), 2015-07-22 20:51:29]

lgtm - I don't have much to say - minor nits below & a question

https://codereview.chromium.org/1229923005/diff/100001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1229923005/diff/100001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:135:
isStatic, isIntercepted, requiredParameterCount,
missing 1 space of indentation (FWIW, I don't think args alignment is worth the
effort, I'd be happy with just +4 here).

https://codereview.chromium.org/1229923005/diff/100001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:187: //
This relies on the fact that types are added *after* the tear-offs have
nit: move the comment above the push call?

https://codereview.chromium.org/1229923005/diff/100001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:733: //
TODO(floitsch): this can be more efficient.
what are you referring to by `this`?

[floitsch, 2015-07-29 17:27:15]

PTAL.
I think I uploaded patch set 7 after you had reviewed this CL. I will wait until
you have had a look at it.

https://codereview.chromium.org/1229923005/diff/100001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1229923005/diff/100001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:135:
isStatic, isIntercepted, requiredParameterCount,
On 2015/07/22 20:51:28, Siggi Cherem (dart-lang) wrote:
> missing 1 space of indentation (FWIW, I don't think args alignment is worth
the
> effort, I'd be happy with just +4 here).

Done.

https://codereview.chromium.org/1229923005/diff/100001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:187: //
This relies on the fact that types are added *after* the tear-offs have
On 2015/07/22 20:51:28, Siggi Cherem (dart-lang) wrote:
> nit: move the comment above the push call?

Done. and added more comments.

https://codereview.chromium.org/1229923005/diff/100001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:733: //
TODO(floitsch): this can be more efficient.
On 2015/07/22 20:51:28, Siggi Cherem (dart-lang) wrote:
> what are you referring to by `this`?

removed.
The tear-off function is redirecting to another function, but in the end it
shouldn't be a bottle-neck.

[floitsch, 2015-08-03 15:02:25]

I want to land all my CLs before we have to cherry-pick them.
So I will land now, but will do follow-up CLs if you have more comments.

[floitsch, 2015-08-03 15:02:36]

Committed patchset #9 (id:160001) manually as
62b49eadc62c6ed9e783298f23e14881d52a41fa (presubmit successful).

[Siggi Cherem (dart-lang), 2015-08-04 03:01:42]

lgtm