Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 1229923003: Revert of Add Unicode Variation Selector support to harfBuzzGetGlyph on Linux (Closed)

Created:
5 years, 5 months ago by jbroman
Modified:
5 years, 5 months ago
Reviewers:
behdad_google, kojii, eae, drott
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add Unicode Variation Selector support to harfBuzzGetGlyph on Linux (patchset #2 id:20001 of https://codereview.chromium.org/1209043010/) Reason for revert: Breaks chromeos=1 builds on Linux. ../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp:201:13: error: use of undeclared identifier 'hb_ot_font_set_funcs' hb_ot_font_set_funcs(hbFontData->m_hbOpenTypeFont); ^ 1 error generated. Original issue's description: > Add Unicode Variation Selector support to harfBuzzGetGlyph on Linux > > Most of the work to support Unicode Variation Selector was done in a > separate CL[1], but it was not enabled for Linux due to crbug.com/462689. > > With the bundled harfbuzz on Linux stabilized, this patch enables the > Unicode Variation Selector support on Linux. > > [1] https://codereview.chromium.org/1149693002 > > BUG=383580 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198565 TBR=eae@chromium.org,behdad@google.com,drott@chromium.org,kojii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=383580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzFace.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jbroman
Created Revert of Add Unicode Variation Selector support to harfBuzzGetGlyph on Linux
5 years, 5 months ago (2015-07-09 15:48:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229923003/1
5 years, 5 months ago (2015-07-09 15:48:39 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 15:49:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198614

Powered by Google App Engine
This is Rietveld 408576698