Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1229913005: Remove ChromeTabbedActivityTestBase.startActivityCompletely(). (Closed)

Created:
5 years, 5 months ago by newt (away)
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeTabbedActivityTestBase.startActivityCompletely(). This method was redundant with the method in ChromeActivityTestCaseBase that it used to override. Committed: https://crrev.com/279ad18a98ec8fa1013aa9fbd210301db9d2fcb4 Cr-Commit-Position: refs/heads/master@{#338188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeTabbedActivityTestBase.java View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
newt (away)
PTAL
5 years, 5 months ago (2015-07-09 22:34:06 UTC) #2
gone
lgtm
5 years, 5 months ago (2015-07-09 22:34:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229913005/1
5 years, 5 months ago (2015-07-09 22:36:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-09 23:10:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229913005/1
5 years, 5 months ago (2015-07-09 23:37:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 23:47:43 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 23:49:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/279ad18a98ec8fa1013aa9fbd210301db9d2fcb4
Cr-Commit-Position: refs/heads/master@{#338188}

Powered by Google App Engine
This is Rietveld 408576698