Fix top-level context menus sorting by name

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 346 matching lines @@
 }
 
 void RenderViewContextMenu::AppendAllExtensionItems() {
   extension_items_.Clear();
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile_)->extension_service();
   if (!service)
     return;  // In unit-tests, we may not have an ExtensionService.
   MenuManager* menu_manager = service->menu_manager();
 
-  // Get a list of extension id's that have context menu items, and sort it by
-  // the extension's name.
+  // TODO(fbeaufort) Use EscapeAmpersands when

[Yoyo Zhou, 2013/03/06 20:18:58]

nit: TODOs should have a colon:
TODO(fbeaufort): Do this.
Anyhow, EscapeAmpersands is now available.

[please use gerrit instead, 2013/03/20 16:29:13]

https://chromiumcodereview.appspot.com/12294022/ has been committed. You can use
EscapeAmpersands now.

+  // https://chromiumcodereview.appspot.com/12294022/ is committed.
+  string16 printable_selection_text = PrintableSelectionText();
+  // Escape "&" as "&&".
+  for (size_t position = printable_selection_text.find('&');
+       position != string16::npos;
+       position = printable_selection_text.find('&', position + 2))
+    printable_selection_text.insert(position, 1, '&');
+
+  // Get a list of extension id's that have context menu items, and sort by the
+  // top level context menu title of the extension.
   std::set<std::string> ids = menu_manager->ExtensionIds();
   std::vector<std::pair<std::string, std::string> > sorted_ids;
   for (std::set<std::string>::iterator i = ids.begin(); i != ids.end(); ++i) {
     const Extension* extension = service->GetExtensionById(*i, false);
     // Platform apps have their context menus created directly in
     // AppendPlatformAppItems.
-    if (extension && !extension->is_platform_app())
+    if (extension && !extension->is_platform_app()) {
+      std::string menu_title = extension_items_.GetTopLevelContextMenuTitle(
+          *i, printable_selection_text);
       sorted_ids.push_back(
-          std::pair<std::string, std::string>(extension->name(), *i));
+          std::pair<std::string, std::string>(menu_title, *i));
+    }
   }
   // TODO(asargent) - See if this works properly for i18n names (bug 32363).
   std::sort(sorted_ids.begin(), sorted_ids.end());
 
   if (sorted_ids.empty())
     return;
 
   int index = 0;
   base::TimeTicks begin = base::TimeTicks::Now();
   std::vector<std::pair<std::string, std::string> >::const_iterator i;
-  for (i = sorted_ids.begin();
-       i != sorted_ids.end(); ++i) {
-    string16 printable_selection_text = PrintableSelectionText();
-    // Escape "&" as "&&".
-    for (size_t position = printable_selection_text.find('&');
-         position != string16::npos;
-         position = printable_selection_text.find('&', position + 2))
-      printable_selection_text.insert(position, 1, '&');
-
+  for (i = sorted_ids.begin(); i != sorted_ids.end(); ++i)
     extension_items_.AppendExtensionItems(i->second, printable_selection_text,
                                           &index);
-  }
   UMA_HISTOGRAM_TIMES("Extensions.ContextMenus_BuildTime",
                       base::TimeTicks::Now() - begin);
   UMA_HISTOGRAM_COUNTS("Extensions.ContextMenus_ItemCount", index);
 }
 
 void RenderViewContextMenu::InitMenu() {
   chrome::ViewType view_type = chrome::GetViewType(source_web_contents_);
   if (view_type == chrome::VIEW_TYPE_APP_SHELL) {
     AppendPlatformAppItems();
     return;
@@ skipping 1462 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }