Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: src/hydrogen-instructions.h

Issue 12299009: Integer HConstants don't need to kDependsOnOsrEntries (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: restrict to integer constants Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3163 matching lines...) Expand 10 before | Expand all | Expand 10 after
3174 BitCast<int64_t>(double_value_) == 3174 BitCast<int64_t>(double_value_) ==
3175 BitCast<int64_t>(other_constant->double_value_); 3175 BitCast<int64_t>(other_constant->double_value_);
3176 } else { 3176 } else {
3177 ASSERT(!handle_.is_null()); 3177 ASSERT(!handle_.is_null());
3178 return !other_constant->handle_.is_null() && 3178 return !other_constant->handle_.is_null() &&
3179 handle_.is_identical_to(other_constant->handle_); 3179 handle_.is_identical_to(other_constant->handle_);
3180 } 3180 }
3181 } 3181 }
3182 3182
3183 private: 3183 private:
3184 void Initialize(Representation r);
3185
3184 virtual bool IsDeletable() const { return true; } 3186 virtual bool IsDeletable() const { return true; }
3185 3187
3186 // If this is a numerical constant, handle_ either points to to the 3188 // If this is a numerical constant, handle_ either points to to the
3187 // HeapObject the constant originated from or is null. If the 3189 // HeapObject the constant originated from or is null. If the
3188 // constant is non-numeric, handle_ always points to a valid 3190 // constant is non-numeric, handle_ always points to a valid
3189 // constant HeapObject. 3191 // constant HeapObject.
3190 Handle<Object> handle_; 3192 Handle<Object> handle_;
3191 3193
3192 // We store the HConstant in the most specific form safely possible. 3194 // We store the HConstant in the most specific form safely possible.
3193 // The two flags, has_int32_value_ and has_double_value_ tell us if 3195 // The two flags, has_int32_value_ and has_double_value_ tell us if
(...skipping 2925 matching lines...) Expand 10 before | Expand all | Expand 10 after
6119 virtual bool IsDeletable() const { return true; } 6121 virtual bool IsDeletable() const { return true; }
6120 }; 6122 };
6121 6123
6122 6124
6123 #undef DECLARE_INSTRUCTION 6125 #undef DECLARE_INSTRUCTION
6124 #undef DECLARE_CONCRETE_INSTRUCTION 6126 #undef DECLARE_CONCRETE_INSTRUCTION
6125 6127
6126 } } // namespace v8::internal 6128 } } // namespace v8::internal
6127 6129
6128 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6130 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698