Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 12299008: Stop resolving all of js_helper unconditionally. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 18614)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -2655,8 +2655,7 @@
void argumentsCheck() {
HInstruction typeInfo = getRuntimeTypeInfo(expression);
- Element helper =
- compiler.findHelper(const SourceString('checkArguments'));
+ Element helper = backend.getCheckArguments();
HInstruction helperCall = new HStatic(helper);
add(helperCall);
List<HInstruction> representations =
@@ -3069,8 +3068,7 @@
Constant internalNameConstant =
constantSystem.createString(new DartString.literal(internalName), node);
- Element createInvocationMirror =
- compiler.findHelper(Compiler.CREATE_INVOCATION_MIRROR);
+ Element createInvocationMirror = backend.getCreateInvocationMirror();
var arguments = new List<HInstruction>();
if (node.argumentsNode != null) {
@@ -3456,8 +3454,7 @@
{Link<Node> argumentNodes,
List<HInstruction> argumentValues,
List<String> existingArguments}) {
- Element helper =
- compiler.findHelper(const SourceString('throwNoSuchMethod'));
+ Element helper = backend.getThrowNoSuchMethod();
Constant receiverConstant =
constantSystem.createString(new DartString.empty(), diagnosticNode);
HInstruction receiver = graph.addConstant(receiverConstant);
@@ -4186,8 +4183,7 @@
List<List<Constant>> matchExpressions = <List<Constant>>[];
List<HStatementInformation> statements = <HStatementInformation>[];
bool hasDefault = false;
- Element getFallThroughErrorElement =
- compiler.findHelper(const SourceString("getFallThroughError"));
+ Element getFallThroughErrorElement = backend.getFallThroughError();
HasNextIterator<Node> caseIterator =
new HasNextIterator<Node>(node.cases.iterator);
while (caseIterator.hasNext) {

Powered by Google App Engine
This is Rietveld 408576698