Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/mips/assembler-mips.cc

Issue 1229863004: MIPS: Fix BlockTrampolinePoolFor() to emit trampoline before blocking, if needed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/assembler-mips.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2838 matching lines...) Expand 10 before | Expand all | Expand 10 after
2849 ClearRecordedAstId(); 2849 ClearRecordedAstId();
2850 reloc_info_writer.Write(&reloc_info_with_ast_id); 2850 reloc_info_writer.Write(&reloc_info_with_ast_id);
2851 } else { 2851 } else {
2852 reloc_info_writer.Write(&rinfo); 2852 reloc_info_writer.Write(&rinfo);
2853 } 2853 }
2854 } 2854 }
2855 } 2855 }
2856 2856
2857 2857
2858 void Assembler::BlockTrampolinePoolFor(int instructions) { 2858 void Assembler::BlockTrampolinePoolFor(int instructions) {
2859 CheckTrampolinePoolQuick(instructions);
2859 BlockTrampolinePoolBefore(pc_offset() + instructions * kInstrSize); 2860 BlockTrampolinePoolBefore(pc_offset() + instructions * kInstrSize);
2860 } 2861 }
2861 2862
2862 2863
2863 void Assembler::CheckTrampolinePool() { 2864 void Assembler::CheckTrampolinePool() {
2864 // Some small sequences of instructions must not be broken up by the 2865 // Some small sequences of instructions must not be broken up by the
2865 // insertion of a trampoline pool; such sequences are protected by setting 2866 // insertion of a trampoline pool; such sequences are protected by setting
2866 // either trampoline_pool_blocked_nesting_ or no_trampoline_pool_before_, 2867 // either trampoline_pool_blocked_nesting_ or no_trampoline_pool_before_,
2867 // which are both checked here. Also, recursive calls to CheckTrampolinePool 2868 // which are both checked here. Also, recursive calls to CheckTrampolinePool
2868 // are blocked by trampoline_pool_blocked_nesting_. 2869 // are blocked by trampoline_pool_blocked_nesting_.
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
3093 if (patched) { 3094 if (patched) {
3094 CpuFeatures::FlushICache(pc + 2, sizeof(Address)); 3095 CpuFeatures::FlushICache(pc + 2, sizeof(Address));
3095 } 3096 }
3096 } 3097 }
3097 3098
3098 3099
3099 } // namespace internal 3100 } // namespace internal
3100 } // namespace v8 3101 } // namespace v8
3101 3102
3102 #endif // V8_TARGET_ARCH_MIPS 3103 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/assembler-mips.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698