Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1229863004: MIPS: Fix BlockTrampolinePoolFor() to emit trampoline before blocking, if needed. (Closed)

Created:
5 years, 5 months ago by paul.l...
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix BlockTrampolinePoolFor() to emit trampoline before blocking, if needed. Fixes possible failure in AssembleArchTableSwitch(). BUG=v8:4294 LOG=y Committed: https://crrev.com/f0d1106a3fa1ffaa822efc90d61e2aca315cbe15 Cr-Commit-Position: refs/heads/master@{#29589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -6 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 2 chunks +87 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
I put the test case in test-macro-assembler-mips rather than test-run-machops/RunSwitch..., as the failure mode is ...
5 years, 5 months ago (2015-07-13 07:04:51 UTC) #2
Benedikt Meurer
lgtm
5 years, 5 months ago (2015-07-13 07:05:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229863004/1
5 years, 5 months ago (2015-07-13 07:05:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 07:28:31 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 07:28:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0d1106a3fa1ffaa822efc90d61e2aca315cbe15
Cr-Commit-Position: refs/heads/master@{#29589}

Powered by Google App Engine
This is Rietveld 408576698