Base: Make TimeDelta constructors deal with overflow.

cc/scheduler/compositor_timing_history.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/scheduler/compositor_timing_history.h"
 
 #include "base/metrics/histogram.h"
 #include "base/trace_event/trace_event.h"
 #include "cc/debug/rendering_stats_instrumentation.h"
 
@@ skipping 27 matching lines @@
 // The estimates related to main-thread responsiveness affect whether
 // we attempt to recovery latency or not and use the 50th percentile.
 // TODO(brianderson): Fine tune the percentiles below.
 const size_t kDurationHistorySize = 60;
 const double kBeginMainFrameToCommitEstimationPercentile = 50.0;
 const double kCommitToReadyToActivateEstimationPercentile = 50.0;
 const double kPrepareTilesEstimationPercentile = 100.0;
 const double kActivateEstimationPercentile = 100.0;
 const double kDrawEstimationPercentile = 100.0;
 
-const base::TimeDelta kUmaDurationMin = base::TimeDelta::FromMicroseconds(1);
-const base::TimeDelta kUmaDurationMax = base::TimeDelta::FromSeconds(1);
+const int kUmaDurationMin_uS = 1;
+const int64 kUmaDurationMax_uS = 1 * base::Time::kMicrosecondsPerSecond;
 const size_t kUmaDurationBucketCount = 100;
 
 // Deprecated because they combine Browser and Renderer stats and have low
 // precision.
 // TODO(brianderson): Remove.
 void DeprecatedDrawDurationUMA(base::TimeDelta duration,
                                base::TimeDelta estimate) {
   base::TimeDelta duration_overestimate;
   base::TimeDelta duration_underestimate;
   if (duration > estimate)
     duration_underestimate = duration - estimate;
   else
     duration_overestimate = estimate - duration;
   UMA_HISTOGRAM_CUSTOM_TIMES("Renderer.DrawDuration", duration,
                              base::TimeDelta::FromMilliseconds(1),
                              base::TimeDelta::FromMilliseconds(100), 50);
   UMA_HISTOGRAM_CUSTOM_TIMES("Renderer.DrawDurationUnderestimate",
                              duration_underestimate,
                              base::TimeDelta::FromMilliseconds(1),
                              base::TimeDelta::FromMilliseconds(100), 50);
   UMA_HISTOGRAM_CUSTOM_TIMES("Renderer.DrawDurationOverestimate",
                              duration_overestimate,
                              base::TimeDelta::FromMilliseconds(1),
                              base::TimeDelta::FromMilliseconds(100), 50);
 }
 
-#define UMA_HISTOGRAM_CUSTOM_TIMES_MICROS(name, sample)                \
-  UMA_HISTOGRAM_CUSTOM_COUNTS(                                         \
-      name, sample.InMicroseconds(), kUmaDurationMin.InMicroseconds(), \
-      kUmaDurationMax.InMicroseconds(), kUmaDurationBucketCount);
+#define UMA_HISTOGRAM_CUSTOM_TIMES_MICROS(name, sample)  \
+  UMA_HISTOGRAM_CUSTOM_COUNTS(                           \
+      name, sample.InMicroseconds(), kUmaDurationMin_uS, \
+      kUmaDurationMax_uS, kUmaDurationBucketCount);
 
 #define REPORT_COMPOSITOR_TIMING_HISTORY_UMA(category, subcategory)            \
   do {                                                                         \
     base::TimeDelta duration_overestimate;                                     \
     base::TimeDelta duration_underestimate;                                    \
     if (duration > estimate)                                                   \
       duration_underestimate = duration - estimate;                            \
     else                                                                       \
       duration_overestimate = estimate - duration;                             \
     UMA_HISTOGRAM_CUSTOM_TIMES_MICROS(                                         \
@@ skipping 300 matching lines @@
   uma_reporter_->AddDrawDuration(draw_duration, draw_estimate, enabled_);
 
   if (enabled_) {
     draw_duration_history_.InsertSample(draw_duration);
   }
 
   start_draw_time_ = base::TimeTicks();
 }
 
 }  // namespace cc