Issue 12298037: Revert 183123

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12298037: Revert 183123 (Closed)

Created:
7 years, 10 months ago by karen

Modified:
7 years, 10 months ago

Reviewers:
vasilii

CC:
chromium-reviews, yusukes+watch_chromium.org, davemoore+watch_chromium.org, Raghu Simha, nkostylev+watch_chromium.org, jam, penghuang+watch_chromium.org, dcheng, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org, oshima+watch_chromium.org, tfarina, chromium-apps-reviews_chromium.org, haitaol1, James Su, stevenjb+watch_chromium.org, tim (not reviewing), akalin

Base URL:
svn://svn.chromium.org/chrome/branches/1417/src/

Visibility:
Public.

More Reviews

Description

Revert 183123 > Part I: clear primary and selection clipboards if data came from content area. > > BUG=171974 > TBR=asargent,sky > > Review URL: https://chromiumcodereview.appspot.com/12041078 TBR=vasilii@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183215

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -626 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/active_tab_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/identity/identity_api.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/system_indicator/system_indicator_manager.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/tabs/ash_panel_contents.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/app_window_contents.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/event_router.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/page_action_controller.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/plugin_apitest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/script_badge_controller.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/script_bubble_controller.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/web_view_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_standalone_install_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/browser/profiles/incognito_selection_clipboard_uitest.cc	View	1 chunk	+0 lines, -124 lines	0 comments	Download
M	chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
MM	chrome/browser/ui/tabs/tab_strip_model.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/browser_action_view.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/native_app_window_views.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/select_file_dialog_extension.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/browser_context.cc	View	4 chunks	+0 lines, -49 lines	0 comments	Download
D	content/browser/renderer_host/clipboard_browsertest.cc	View	1 chunk	+0 lines, -73 lines	0 comments	Download
M	content/browser/renderer_host/clipboard_message_filter.h	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/clipboard_message_filter.cc	View	5 chunks	+18 lines, -33 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_gtk.cc	View	3 chunks	+4 lines, -9 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/browser/browser_context.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	ui/base/clipboard/clipboard.h	View	9 chunks	+1 line, -34 lines	0 comments	Download
M	ui/base/clipboard/clipboard.cc	View	3 chunks	+0 lines, -35 lines	0 comments	Download
M	ui/base/clipboard/clipboard_android.cc	View	5 chunks	+1 line, -25 lines	0 comments	Download
M	ui/base/clipboard/clipboard_aurax11.cc	View	8 chunks	+2 lines, -33 lines	0 comments	Download
M	ui/base/clipboard/clipboard_chromeos.cc	View	9 chunks	+1 line, -38 lines	0 comments	Download
M	ui/base/clipboard/clipboard_gtk.cc	View	9 chunks	+13 lines, -46 lines	0 comments	Download
M	ui/base/clipboard/clipboard_mac.mm	View	6 chunks	+1 line, -27 lines	0 comments	Download
M	ui/base/clipboard/clipboard_unittest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/base/clipboard/clipboard_util_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/clipboard/clipboard_util_win.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	ui/base/clipboard/clipboard_win.cc	View	5 chunks	+1 line, -27 lines	0 comments	Download
M	ui/base/clipboard/scoped_clipboard_writer.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/base/clipboard/scoped_clipboard_writer.cc	View	1 chunk	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages