Don't store the DateTimePicker client in a scoped_ptr.

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 3b1a0d3ed68a1126d77182272b9d272a1fd33d8c..8a3ad5c4b02bf256ce838720a6f659d7fb22d646 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -645,6 +645,7 @@ RenderViewImpl::RenderViewImpl(RenderViewImplParams* params)
       expected_content_intent_id_(0),
       media_player_proxy_(NULL),
       synchronous_find_active_match_ordinal_(-1),
+      date_time_picker_client_(NULL),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           load_progress_tracker_(new LoadProgressTracker(this))),
 #endif
@@ -6474,8 +6475,11 @@ void RenderViewImpl::LaunchAndroidContentIntent(const GURL& intent,
 bool RenderViewImpl::openDateTimeChooser(
     const WebKit::WebDateTimeChooserParams& params,
     WebKit::WebDateTimeChooserCompletion* completion) {
-  date_time_picker_client_.reset(
-      new RendererDateTimePicker(this, params, completion));
+  if (date_time_picker_client_ != NULL)

[Miguel Garcia, 2013/02/18 17:48:48]

(I introduced the original bug so thanks a lot for fixing!)

This seems like the simpler approach to fix the problem right now, I would
nevertheless like some feedback on how to solve this in the more general case.
The DateTimePicker client is an observer and as such it seems it should not go
inside a scoped_pointer because observers are destroyed in its own way. However
the picker needs to be regenerated with new input from WebKit.

I see two ways I guess;

Split the picker functionality in two completely different objects (even though
they are very related) and let them be destroyed separately.

Add an "update" method or the like and reuse the picker instead of regenerating
it every time.

Feedback is welcome for the future fix indeed. Note that we have to patch this
in M25 so I would vouch for this simple fix first.

+    delete date_time_picker_client_;
+
+  date_time_picker_client_ = new RendererDateTimePicker(this, params,
+      completion);
   return date_time_picker_client_->Open();
 }