Don't store the DateTimePicker client in a scoped_ptr.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 627 matching lines @@
       renderer_accessibility_(NULL),
       java_bridge_dispatcher_(NULL),
       mouse_lock_dispatcher_(NULL),
       favicon_helper_(NULL),
 #if defined(OS_ANDROID)
       body_background_color_(SK_ColorWHITE),
       update_frame_info_scheduled_(false),
       expected_content_intent_id_(0),
       media_player_proxy_(NULL),
       synchronous_find_active_match_ordinal_(-1),
+      date_time_picker_client_(NULL),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           load_progress_tracker_(new LoadProgressTracker(this))),
 #endif
       session_storage_namespace_id_(params->session_storage_namespace_id),
       handling_select_range_(false),
       next_snapshot_id_(0),
 #if defined(OS_WIN)
       focused_plugin_id_(-1),
 #endif
       updating_frame_tree_(false),
@@ skipping 5809 matching lines @@
   // Remove the content highlighting if any.
   scheduleComposite();
 
   if (!intent.is_empty())
     Send(new ViewHostMsg_StartContentIntent(routing_id_, intent));
 }
 
 bool RenderViewImpl::openDateTimeChooser(
     const WebKit::WebDateTimeChooserParams& params,
     WebKit::WebDateTimeChooserCompletion* completion) {
-  date_time_picker_client_.reset(
-      new RendererDateTimePicker(this, params, completion));
+  if (date_time_picker_client_ != NULL)

[Miguel Garcia, 2013/02/18 17:48:48]

(I introduced the original bug so thanks a lot for fixing!)

This seems like the simpler approach to fix the problem right now, I would
nevertheless like some feedback on how to solve this in the more general case.
The DateTimePicker client is an observer and as such it seems it should not go
inside a scoped_pointer because observers are destroyed in its own way. However
the picker needs to be regenerated with new input from WebKit.

I see two ways I guess;

Split the picker functionality in two completely different objects (even though
they are very related) and let them be destroyed separately.

Add an "update" method or the like and reuse the picker instead of regenerating
it every time.

Feedback is welcome for the future fix indeed. Note that we have to patch this
in M25 so I would vouch for this simple fix first.

+    delete date_time_picker_client_;
+
+  date_time_picker_client_ = new RendererDateTimePicker(this, params,
+      completion);
   return date_time_picker_client_->Open();
 }
 
 #endif  // defined(OS_ANDROID)
 
 void RenderViewImpl::OnAsyncFileOpened(
     base::PlatformFileError error_code,
     IPC::PlatformFileForTransit file_for_transit,
     int message_id) {
   pepper_helper_->OnAsyncFileOpened(
@@ skipping 173 matching lines @@
   TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
   RenderProcess::current()->ReleaseTransportDIB(dib);
 }
 
 void RenderViewImpl::DidCommitCompositorFrame() {
   RenderWidget::DidCommitCompositorFrame();
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidCommitCompositorFrame());
 }
 
 }  // namespace content