Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 12298019: Revert 183089 (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, darin-cc_chromium.org, dmikurube+memory_chromium.org, erikwright+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Revert 183089 Needs owner review > Linux: add option to use system tcmalloc (off by default) > > This changes things only for Linux distros, Google Chrome > will continue to use bundled tcmalloc. > > TBR=darin > > BUG=174634 > > Review URL: https://codereview.chromium.org/12224030 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -510 lines) Patch
M base/allocator/allocator.gyp View 3 chunks +438 lines, -498 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/content_app.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/generate_shim_headers/generate_shim_headers.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jschuh
7 years, 10 months ago (2013-02-18 11:56:51 UTC) #1
Paweł Hajdan Jr.
LGTM I'm sorry this made you upset. My TBR was based on no change for ...
7 years, 10 months ago (2013-02-18 12:00:21 UTC) #2
jschuh
I'm not upset, but I am very concerned at how the original CL was landed. ...
7 years, 10 months ago (2013-02-18 13:04:52 UTC) #3
jschuh
7 years, 10 months ago (2013-02-18 13:15:32 UTC) #4
Message was sent while issue was closed.
Also, to be clear, I'm no stranger to TBR. Particularly since I started the
Win64 port, where I use it many times a week. However, I try very hard to ensure
I use it only for trivial changes that don't impact anything other than Chrome's
Win64 configuration. For anything else I get a review (accepting a few minor
slip ups on my part).

Powered by Google App Engine
This is Rietveld 408576698