chrome/browser/ui/extensions/extension_install_ui_default.cc - Issue 12298015: Change NotifyAppList*() functions into observers on a ProfileKeyedService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_install_ui_default.cc

Issue 12298015: Change NotifyAppList*() functions into observers on a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix mac Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/app_list/app_list_controller_cocoa.mm ('k') | chrome/browser/ui/views/app_list/app_list_controller_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_install_ui_default.cc

diff --git a/chrome/browser/ui/extensions/extension_install_ui_default.cc b/chrome/browser/ui/extensions/extension_install_ui_default.cc

index e8bd56feef4a05155b6bdeca97df00591090a473..b9290472999956abc3e223b191d50e420836e72f 100644

--- a/chrome/browser/ui/extensions/extension_install_ui_default.cc

+++ b/chrome/browser/ui/extensions/extension_install_ui_default.cc

@@ -175,10 +175,6 @@ void ExtensionInstallUIDefault::OnInstallSuccess(const Extension* extension,

Browser* browser =

chrome::FindOrCreateTabbedBrowser(current_profile,

chrome::GetActiveDesktop());

- if (browser->tab_strip_model()->count() == 0)

- chrome::AddBlankTabAt(browser, -1, true);

- browser->window()->Show();

if (extension->is_app()) {

bool use_bubble = false;

@@ -239,6 +235,10 @@ void ExtensionInstallUI::OpenAppInstalledUI(Browser* browser,

content::Source<Profile>(browser->profile()),

content::Details<const std::string>(&app_id));

#else

+ if (browser->tab_strip_model()->count() == 0)

+ chrome::AddBlankTabAt(browser, -1, true);

+ browser->window()->Show();

chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(

browser, GURL(chrome::kChromeUINewTabURL)));

chrome::Navigate(&params);