Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/ui/views/app_list/app_list_controller_win.cc

Issue 12298015: Change NotifyAppList*() functions into observers on a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/app_list/app_list_controller_win.cc
diff --git a/chrome/browser/ui/views/app_list/app_list_controller_win.cc b/chrome/browser/ui/views/app_list/app_list_controller_win.cc
index ec34a32f17511753c27f5ad68702d33d57dbc1e5..3c98378c269d6f8c9df26c5fabac2ff09d9cfa96 100644
--- a/chrome/browser/ui/views/app_list/app_list_controller_win.cc
+++ b/chrome/browser/ui/views/app_list/app_list_controller_win.cc
@@ -878,25 +878,8 @@ class AppListControllerAsh : public AppListController {
virtual void ShowAppList(Profile* profile) OVERRIDE;
virtual void DismissAppList() OVERRIDE;
-
- // The OnBeginExtensionInstall/OnDownloadProgress/OnInstallFalure overrides
- // are not necessary for ASH as these are handled by the ash Shell.
- virtual void OnBeginExtensionInstall(Profile* profile,
- const std::string& extension_id,
- const std::string& extension_name,
- const gfx::ImageSkia& installing_icon)
- OVERRIDE {}
-
- virtual void OnDownloadProgress(Profile* profile,
- const std::string& extension_id,
- int percent_downloaded) OVERRIDE {}
-
virtual bool IsAppListVisible() const OVERRIDE;
- virtual void OnInstallFailure(
- Profile* profile,
- const std::string& extension_id) OVERRIDE {}
-
private:
DISALLOW_COPY_AND_ASSIGN(AppListControllerAsh);
};
@@ -985,29 +968,4 @@ bool IsAppListVisible() {
return GetCurrentAppListController()->IsAppListVisible();
}
-void NotifyAppListOfBeginExtensionInstall(
- Profile* profile,
- const std::string& extension_id,
- const std::string& extension_name,
- const gfx::ImageSkia& installing_icon) {
- GetCurrentAppListController()->OnBeginExtensionInstall(profile,
- extension_id,
- extension_name,
- installing_icon);
-}
-
-void NotifyAppListOfDownloadProgress(
- Profile* profile,
- const std::string& extension_id,
- int percent_downloaded) {
- GetCurrentAppListController()->OnDownloadProgress(profile, extension_id,
- percent_downloaded);
-}
-
-void NotifyAppListOfExtensionInstallFailure(
- Profile* profile,
- const std::string& extension_id) {
- GetCurrentAppListController()->OnInstallFailure(profile, extension_id);
-}
-
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698