Change NotifyAppList*() functions into observers on a ProfileKeyedService.

chrome/browser/ui/app_list/apps_model_builder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APP_LIST_APPS_MODEL_BUILDER_H_
 #define CHROME_BROWSER_UI_APP_LIST_APPS_MODEL_BUILDER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "base/prefs/public/pref_change_registrar.h"
+#include "chrome/browser/extensions/install_observer.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "ui/app_list/app_list_model.h"
 #include "ui/base/models/list_model_observer.h"
 
 class AppListControllerDelegate;
 class ExtensionAppItem;
 class ExtensionSet;
 class Profile;
 
 namespace gfx {
 class ImageSkia;
 }
 
 class AppsModelBuilder : public content::NotificationObserver,
-                         public ui::ListModelObserver {
+                         public ui::ListModelObserver,
+                         public extensions::InstallObserver {
  public:
   AppsModelBuilder(Profile* profile,
                    app_list::AppListModel::Apps* model,
                    AppListControllerDelegate* controller);
   virtual ~AppsModelBuilder();
 
   // Populates the model.
   void Build();
 
-  // Called when an extension starts installing.
-  void OnBeginExtensionInstall(const std::string& extension_id,
-                               const std::string& extension_name,
-                               const gfx::ImageSkia& installing_icon);
-
-  // Called when progress is made on an extension's download.
-  void OnDownloadProgress(const std::string& extension_id,
-                          int percent_downloaded);
-
-  // Called when an extension fails to install.
-  void OnInstallFailure(const std::string& extension_id);
-
  private:
   typedef std::vector<ExtensionAppItem*> Apps;
 
+  // InstallObserver overrides.

[tfarina, 2013/02/25 23:43:02]

extensions::InstallObserver overrides:

Although my preference has always been by:

// Overridden from extensions::InstallObserver:

or

// extensions::InstallObserver:

[koz (OOO until 15th September), 2013/02/26 00:10:51]

Done.

+  virtual void OnBeginExtensionInstall(const std::string& extension_id,
+                                       const std::string& extension_name,
+                                       const gfx::ImageSkia& installing_icon,
+                                       bool is_app) OVERRIDE;
+
+  virtual void OnDownloadProgress(const std::string& extension_id,
+                                  int percent_downloaded) OVERRIDE;
+
+  virtual void OnInstallFailure(const std::string& extension_id) OVERRIDE;
+
   // Adds apps in |extensions| to |apps|.
   void AddApps(const ExtensionSet* extensions, Apps* apps);
 
   // Populates the model with apps.
   void PopulateApps();
 
   // Re-sort apps in case app ordinal prefs are changed.
   void ResortApps();
 
   // Inserts an app based on app ordinal prefs.
@@ skipping 33 matching lines @@
   // True to ignore |model_| changes.
   bool ignore_changes_;
 
   content::NotificationRegistrar registrar_;
   PrefChangeRegistrar pref_change_registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(AppsModelBuilder);
 };
 
 #endif  // CHROME_BROWSER_UI_APP_LIST_APPS_MODEL_BUILDER_H_