tools/build.py - Issue 12298006: Try to better guess Visual Studio path when building Dart on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/build.py

Issue 12298006: Try to better guess Visual Studio path when building Dart on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Got rid of arithmetic comparison with None. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/build.py

diff --git a/tools/build.py b/tools/build.py

index 84aa62b47f797c258c0b5efffdc50de4c7b2c09c..b60579c632ebffb4fd9332d0a7fe758fdef6377e 100755

--- a/tools/build.py

+++ b/tools/build.py

@@ -40,13 +40,14 @@ def BuildOptions():

help='The number of parallel jobs to run.',

metavar=HOST_CPUS,

default=str(HOST_CPUS))

+ (vs_directory, vs_executable) = utils.GuessVisualStudioPath()

result.add_option("--devenv",

help='Path containing devenv.com on Windows',

- default='C:\\Program Files (x86)\\Microsoft Visual Studio 10.0\\Common7'

- '\\IDE')

+ default=vs_directory)

result.add_option("--executable",

help='Name of the devenv.com/msbuild executable on Windows (varies for '

- 'different versions of Visual Studio)', default='devenv.com')

+ 'different versions of Visual Studio)',

+ default=vs_executable)

return result

« no previous file with comments | « no previous file | tools/utils.py » ('j') | no next file with comments »