Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 12298002: Make npapi_test_plugin build on Win64 (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Make npapi_test_plugin build on Win64 Just made some timer callback signatures and a type 64-bit safe. BUG=166496 R=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183036

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M webkit/plugins/npapi/test/plugin_get_javascript_url_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_get_javascript_url_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_geturl_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_lifetime_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jschuh
PTAL. Trivial compile fixes.
7 years, 10 months ago (2013-02-17 00:45:01 UTC) #1
Bernhard Bauer
7 years, 10 months ago (2013-02-17 13:29:36 UTC) #2
Rubber-stamp LGTM.

Powered by Google App Engine
This is Rietveld 408576698