Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1229793002: Provide an API that allows a RenderObject's performLayout() function to call a callback that mutate… (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Provide an API that allows a RenderObject's performLayout() function to call a callback that mutates the render tree during layout. Also, provide a removeAll() function on ContainerRenderObjectMixin. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fb8f55d880f239d3eac5a670c2bcc7f35ab957a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -27 lines) Patch
M sky/sdk/lib/rendering/box.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/rendering/object.dart View 10 chunks +92 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-09 00:43:11 UTC) #2
Hixie
5 years, 5 months ago (2015-07-09 00:54:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb8f55d880f239d3eac5a670c2bcc7f35ab957a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698