Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: sky/shell/testing/test_runner.h

Issue 1229743002: Teach sky_shell.exe to run from a snapshot (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/shell/linux/main.cc ('k') | sky/shell/testing/test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/shell/testing/test_runner.h
diff --git a/sky/shell/testing/test_runner.h b/sky/shell/testing/test_runner.h
index 7b326abd554ab7cdc47c6b7df4e7eda7eab18c55..82d34ed46fc3eb6e0e8e120a46ebcbb97f9bd67b 100644
--- a/sky/shell/testing/test_runner.h
+++ b/sky/shell/testing/test_runner.h
@@ -27,7 +27,12 @@ class TestRunner : public mojo::InterfaceFactory<TestHarness>,
package_root_ = package_root;
}
- void Start(const std::string& single_test_url);
+ struct SingleTest {
+ std::string path;
+ bool is_snapshot = false;
+ };
+
+ void Start(scoped_ptr<SingleTest> single_test);
private:
// mojo::InterfaceFactory<TestHarness> implementation:
@@ -48,7 +53,7 @@ class TestRunner : public mojo::InterfaceFactory<TestHarness>,
scoped_ptr<ShellView> shell_view_;
SkyEnginePtr sky_engine_;
- std::string single_test_url_;
+ scoped_ptr<SingleTest> single_test_;
mojo::WeakBindingSet<TestHarness> bindings_;
base::WeakPtrFactory<TestRunner> weak_ptr_factory_;
« no previous file with comments | « sky/shell/linux/main.cc ('k') | sky/shell/testing/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698