Issue 1229743002: Teach sky_shell.exe to run from a snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1229743002: Teach sky_shell.exe to run from a snapshot (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach sky_shell.exe to run from a snapshot Also, make stocks robust to failing network connections. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a25d55296113a7e6f4d4584db18e73b959e6b97b

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -28 lines)			Patch
M	sky/sdk/example/stocks/lib/stock_data.dart	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/mojo/net/fetch.dart	View	1 chunk	+14 lines, -8 lines	0 comments	Download
M	sky/shell/linux/main.cc	View	3 chunks	+19 lines, -9 lines	0 comments	Download
M	sky/shell/testing/test_runner.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	sky/shell/testing/test_runner.cc	View	5 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-08 22:50:10 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a25d55296113a7e6f4d4584db18e73b959e6b97b (presubmit successful).

Expand Messages | Collapse Messages