Add net logging for ServiceWorkerURLRequestJob.

Add net logging for ServiceWorkerURLRequestJob.

This patch adds net log types for each ServiceWorkerURLRequestJob result type
(already used for UMA), and logs the result as a net event. This may help
debugging user issues when something goes wrong with Service Worker.

It also folds DESTROYED and KILLED UMAs into just KILLED,
as it turned out we got no DESTROYED UMAs.

BUG=499143
Committed: https://crrev.com/adacabbf290abae3e862d21b8549fd3a490e2303
Cr-Commit-Position: refs/heads/master@{#338207}

[falken, 2015-07-09 04:35:58]

falken@chromium.org changed reviewers:
+ kinuko@chromium.org, michaeln@chromium.org

[falken, 2015-07-09 04:35:59]

WDYT?

[kinuko, 2015-07-09 13:52:41]

I'm not familiar with NetLog and probably not a good reviewer here, but this
looks reasonable.

https://codereview.chromium.org/1229733003/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_url_request_job.cc (left):

https://codereview.chromium.org/1229733003/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_url_request_job.cc:355: //
DESTROYED results together.
So we didn't see many of these?

[falken, 2015-07-09 14:26:28]

falken@chromium.org changed reviewers:
+ mmenke@chromium.org

[falken, 2015-07-09 14:26:29]

+mmenke: can you please review?

https://codereview.chromium.org/1229733003/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_url_request_job.cc (left):

https://codereview.chromium.org/1229733003/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_url_request_job.cc:355: //
DESTROYED results together.
On 2015/07/09 13:52:41, kinuko wrote:
> So we didn't see many of these?

Right, there were zero of these.

[mmenke, 2015-07-09 14:57:45]

LGTM

https://codereview.chromium.org/1229733003/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/1229733003/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1824: // to responds with a network error.
nit:  responds->respond

[falken, 2015-07-10 01:01:45]

Patchset #2 (id:20001) has been deleted

[falken, 2015-07-10 01:01:54]

Patchset #2 (id:40001) has been deleted

[falken, 2015-07-10 01:10:18]

Thanks!

https://codereview.chromium.org/1229733003/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/1229733003/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1824: // to responds with a network error.
On 2015/07/09 14:57:44, mmenke wrote:
> nit:  responds->respond

Done. Fixed a few other grammar issues also.

https://codereview.chromium.org/1229733003/diff/80001/content/browser/service...
File content/browser/service_worker/service_worker_url_request_job.cc (right):

https://codereview.chromium.org/1229733003/diff/80001/content/browser/service...
content/browser/service_worker/service_worker_url_request_job.cc:417: if
(request()) {
Added this check: it looks conceivable for request() to be null here since this
function is called asynchronously. Since I'm landing close to branch and might
merge to 44, I really want this patch to just add  logging and have no possible
behavior change.

[falken, 2015-07-10 01:11:37]

The CQ bit was checked by falken@chromium.org

[falken, 2015-07-10 01:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1229733003/#ps80001
(title: "add slighty paranoid null check")

[commit-bot: I haz the power, 2015-07-10 01:13:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229733003/80001

[commit-bot: I haz the power, 2015-07-10 02:32:05]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-07-10 02:34:12]

Patchset 3 (id:??) landed as
https://crrev.com/adacabbf290abae3e862d21b8549fd3a490e2303
Cr-Commit-Position: refs/heads/master@{#338207}