Refactor the length functions to remove passing around the extra bool parameter for rounding behavi…

Source/core/css/CSSLengthFunctions.cpp

 /*
     Copyright (C) 1999 Lars Knoll (knoll@kde.org)
     Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
     Copyright (C) 2011 Rik Cabanier (cabanier@adobe.com)
     Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
     Copyright (C) 2012 Motorola Mobility, Inc. All rights reserved.
     Copyright (C) 2013 Google, Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
@@ skipping 13 matching lines @@
 
 #include "config.h"
 #include "core/css/CSSLengthFunctions.h"
 
 #include "platform/LayoutUnit.h"
 #include "platform/Length.h"
 #include "platform/LengthFunctions.h"
 
 namespace WebCore {
 
-int minimumIntValueForLength(const Length& length, LayoutUnit maximumValue, bool roundPercentages)
+int minimumIntValueForLength(const Length& length, LayoutUnit maximumValue)
 {
-    return static_cast<int>(minimumValueForLength(length, maximumValue, roundPercentages));
+    return static_cast<int>(minimumValueForLength(length, maximumValue));
 }
 
-int intValueForLength(const Length& length, LayoutUnit maximumValue, bool roundPercentages)
+int intValueForLength(const Length& length, LayoutUnit maximumValue)
 {
-    return static_cast<int>(valueForLength(length, maximumValue, roundPercentages));
+    return static_cast<int>(valueForLength(length, maximumValue));
 }
 
-LayoutUnit minimumValueForLength(const Length& length, LayoutUnit maximumValue, bool roundPercentages)
+LayoutUnit minimumValueForLength(const Length& length, LayoutUnit maximumValue)
 {
     switch (length.type()) {
     case Fixed:
         return length.value();
     case Percent:
-        if (roundPercentages)
-            return static_cast<LayoutUnit>(round(maximumValue * length.percent() / 100.0f));
         // Don't remove the extra cast to float. It is needed for rounding on 32-bit Intel machines that use the FPU stack.
         return static_cast<float>(maximumValue * length.percent() / 100.0f);
     case Calculated:
         return length.nonNanCalculatedValue(maximumValue);
     case FillAvailable:
     case Auto:
         return 0;
     case Intrinsic:
     case MinIntrinsic:
     case MinContent:
     case MaxContent:
     case FitContent:
     case ExtendToZoom:
     case DeviceWidth:
     case DeviceHeight:
     case Undefined:
         ASSERT_NOT_REACHED();
         return 0;
     }
     ASSERT_NOT_REACHED();
     return 0;
 }
 
-LayoutUnit valueForLength(const Length& length, LayoutUnit maximumValue, bool roundPercentages)
+LayoutUnit roundedMinimumValueForLength(const Length& length, LayoutUnit maximumValue)
+{
+    if (length.type() == Percent)
+        return static_cast<LayoutUnit>(round(maximumValue * length.percent() / 100.0f));
+    return minimumValueForLength(length, maximumValue);
+}
+
+LayoutUnit valueForLength(const Length& length, LayoutUnit maximumValue)
 {
     switch (length.type()) {
     case Fixed:
     case Percent:
     case Calculated:
-        return minimumValueForLength(length, maximumValue, roundPercentages);
+        return minimumValueForLength(length, maximumValue);
     case FillAvailable:
     case Auto:
         return maximumValue;
     case Intrinsic:
     case MinIntrinsic:
     case MinContent:
     case MaxContent:
     case FitContent:
     case ExtendToZoom:
     case DeviceWidth:
     case DeviceHeight:
     case Undefined:
         ASSERT_NOT_REACHED();
         return 0;
     }
     ASSERT_NOT_REACHED();
     return 0;
 }
 
 } // namespace WebCore