Issue 122973002: Refactor the length functions to remove passing around the extra bool parameter for rounding behavi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122973002: Refactor the length functions to remove passing around the extra bool parameter for rounding behavi… (Closed)

Created:
6 years, 11 months ago by atreat

Modified:
6 years, 11 months ago

Reviewers:
Inactive, adamk, eseidel

CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Refactor the length functions to remove passing around the extra bool parameter for rounding behavior that is only used in a few places. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164471

Patch Set 1 #

Patch Set 2 : Rebase to apply #

Patch Set 3 : Try again #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
M	Source/core/css/CSSLengthFunctions.h	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	Source/core/css/CSSLengthFunctions.cpp	View	1	2 chunks	+14 lines, -9 lines	0 comments	Download
M	Source/core/rendering/RenderBoxModelObject.cpp	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

atreat

Just a small refactor to eliminate an extra parameter making the code a bit messy.

6 years, 11 months ago (2013-12-31 19:44:23 UTC) #2

atreat

On 2013/12/31 19:44:23, atreat wrote: > Just a small refactor to eliminate an extra parameter ...

6 years, 11 months ago (2014-01-03 15:07:00 UTC) #3

Inactive

lgtm It makes the code more readable, there is no functionality change and it gets ...

6 years, 11 months ago (2014-01-03 20:04:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/122973002/170001

6 years, 11 months ago (2014-01-03 20:45:21 UTC) #5

Message was sent while issue was closed.

Change committed as 164471

Expand Messages | Collapse Messages