Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Issue 1229713002: Keep the original contents when showing the distilled one (Closed)

Created:
5 years, 5 months ago by aruslan
Modified:
5 years, 5 months ago
Reviewers:
mdjones, cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep the original contents when showing the distilled one This is one of the possible M-45 solutions for http://crbug.com/504191. Unfortunately, it introduces at most one non-leaking but unnecessary WebContents per tab being held after the distillation was used on the tab. The proper solution discussed with mdjones@ involves discarding the cached original page WebContents on any navigation (except going back) and using it for the rapid back-press. Given that the direction for M-46 is to switch the Reader Mode view to be an overlay (like CS) it is understood to be unnecessary and unfeasible to complicate M-45, as this code is going to be rewritten anyway. BUG=504191 Committed: https://crrev.com/78c6498159eb896a150d50c502747d63915d107c Cr-Commit-Position: refs/heads/master@{#338380}

Patch Set 1 #

Patch Set 2 : Removed an unrelated change. #

Patch Set 3 : Works with chrome://inspect. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModePanel.java View 1 2 6 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
aruslan
Matthew, PTAL, thanks!
5 years, 5 months ago (2015-07-08 21:59:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229713002/40001
5 years, 5 months ago (2015-07-08 22:00:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-08 22:45:26 UTC) #6
mdjones
As we discussed, this CL allows a third WebContents to exist if a user navigates ...
5 years, 5 months ago (2015-07-09 00:56:04 UTC) #7
aruslan
Chris PTAL, thanks!
5 years, 5 months ago (2015-07-10 20:13:52 UTC) #9
cjhopman
lgtm
5 years, 5 months ago (2015-07-10 21:35:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229713002/40001
5 years, 5 months ago (2015-07-10 21:39:38 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-10 22:16:50 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 22:17:38 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/78c6498159eb896a150d50c502747d63915d107c
Cr-Commit-Position: refs/heads/master@{#338380}

Powered by Google App Engine
This is Rietveld 408576698