Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3496)

Unified Diff: cc/scrollbar_layer_impl.cc

Issue 12297009: cc: SolidColorQuad-based scrollbars for Android [M25] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scrollbar_layer_impl.cc
diff --git a/cc/scrollbar_layer_impl.cc b/cc/scrollbar_layer_impl.cc
index f0b5f7f0d2cd916a24da8e61df15e447b4652247..0343cda0a588b40bed9af3f8113dc12f923a579c 100644
--- a/cc/scrollbar_layer_impl.cc
+++ b/cc/scrollbar_layer_impl.cc
@@ -5,8 +5,10 @@
#include "cc/scrollbar_layer_impl.h"
#include "cc/layer_tree_impl.h"
+#include "cc/layer_tree_settings.h"
#include "cc/quad_sink.h"
#include "cc/scrollbar_animation_controller.h"
+#include "cc/solid_color_draw_quad.h"
#include "cc/texture_draw_quad.h"
#include "ui/gfx/rect_conversions.h"
@@ -151,6 +153,18 @@ void ScrollbarLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& append
if (!m_geometry->hasThumb(&m_scrollbar))
thumbRect = WebRect();
+ if (layerTreeImpl()->settings().solidColorScrollbars) {
+ if (m_scrollbar.orientation() == WebScrollbar::Horizontal)
+ thumbRect.height -= layerTreeImpl()->settings().solidColorScrollbarMargin;
+ else
+ thumbRect.width -= layerTreeImpl()->settings().solidColorScrollbarMargin;
+ gfx::Rect quadRect(scrollbarLayerRectToContentRect(thumbRect));
+ scoped_ptr<SolidColorDrawQuad> quad = SolidColorDrawQuad::Create();
+ quad->SetNew(sharedQuadState, quadRect, layerTreeImpl()->settings().solidColorScrollbarColor);
+ quadSink.append(quad.PassAs<DrawQuad>(), appendQuadsData);
+ return;
+ }
+
if (m_thumbResourceId && !thumbRect.isEmpty()) {
gfx::Rect quadRect(scrollbarLayerRectToContentRect(thumbRect));
gfx::Rect opaqueRect;

Powered by Google App Engine
This is Rietveld 408576698