Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 12297009: cc: SolidColorQuad-based scrollbars for Android [M25] (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, trchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: SolidColorQuad-based scrollbars for Android This adds new LayerTreeSettings for enabling SolidColorQuad scrollbars as well as setting their color and thickness. When enabled, no textures will be uploaded and only the thumb will be displayed. Note that the scrollbar thickness coming from WebCore is assumed to include the margin. NOTRY=true BUG=176778 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183431

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 2

Patch Set 3 : Fix review nits #

Patch Set 4 : Switch from margin to thickness #

Total comments: 4

Patch Set 5 : Added test that no resources are uploaded #

Patch Set 6 : Rename to solidColorScrollbarThicknessDIP #

Total comments: 2

Patch Set 7 : Add quad geometry test #

Patch Set 8 : Fix DCHECK failure in test by creating render surface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
M cc/layer_tree_settings.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M cc/layer_tree_settings.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M cc/scrollbar_layer.cc View 1 4 chunks +12 lines, -0 lines 0 comments Download
M cc/scrollbar_layer_impl.cc View 1 2 3 4 5 2 chunks +17 lines, -0 lines 0 comments Download
M cc/scrollbar_layer_unittest.cc View 1 2 3 4 5 6 7 3 chunks +129 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
aelias_OOO_until_Jul13
Hi James, I tried to pass the information through via WebScrollbar but it looks like ...
7 years, 10 months ago (2013-02-18 04:18:54 UTC) #1
jamesr
At this point, is there any reason to use the geometry from WebKit at all? ...
7 years, 10 months ago (2013-02-18 04:51:47 UTC) #2
aelias_OOO_until_Jul13
OK, nits addressed. I just tried to write a version that avoids the geometry entirely ...
7 years, 10 months ago (2013-02-18 08:29:13 UTC) #3
jamesr
On 2013/02/18 08:29:13, aelias wrote: > OK, nits addressed. > > I just tried to ...
7 years, 10 months ago (2013-02-19 20:21:51 UTC) #4
jamesr
https://codereview.chromium.org/12297009/diff/1007/cc/layer_tree_settings.cc File cc/layer_tree_settings.cc (right): https://codereview.chromium.org/12297009/diff/1007/cc/layer_tree_settings.cc#newcode33 cc/layer_tree_settings.cc:33: , solidColorScrollbarColor(SkColorSetARGB(255, 255, 255, 255)) SK_ColorWHITE https://codereview.chromium.org/12297009/diff/1007/cc/layer_tree_settings.h File cc/layer_tree_settings.h ...
7 years, 10 months ago (2013-02-19 20:21:58 UTC) #5
anagy4698
index 69100bf40f109da3ec3180c5db190e44615a06cb .. 278ddf77a4963ef496dcce37666860b88ca0a1cf 100644 2013/2/19 <jamesr@chromium.org> > On 2013/02/18 08:29:13, aelias wrote: > >> ...
7 years, 10 months ago (2013-02-19 20:23:27 UTC) #6
aelias_OOO_until_Jul13
Added a test. I can't avoid depending on the WebKit geometry entirely since WebKit sets ...
7 years, 10 months ago (2013-02-20 00:01:16 UTC) #7
jamesr
thumb thickness math doesn't look right, and it isn't tested, but fix that and lgtm ...
7 years, 10 months ago (2013-02-20 01:49:01 UTC) #8
aelias_OOO_until_Jul13
OK, added a test that checks the draw quad size in the presence of scale. ...
7 years, 10 months ago (2013-02-20 05:26:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12297009/20001
7 years, 10 months ago (2013-02-20 07:31:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12297009/20001
7 years, 10 months ago (2013-02-20 07:37:16 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 08:12:00 UTC) #12
Message was sent while issue was closed.
Change committed as 183431

Powered by Google App Engine
This is Rietveld 408576698