gm/imagefiltersscaled.cpp - Issue 1229693009: Add new SkPoint3 class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/imagefiltersscaled.cpp

Issue 1229693009: Add new SkPoint3 class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: move files Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/imagefiltersscaled.cpp

diff --git a/gm/imagefiltersscaled.cpp b/gm/imagefiltersscaled.cpp

index 9a80964a0e6e595777d60cb0c30a1634cc1ed4aa..e7a68d747d69b140872552e398e5d3daee57450d 100644

--- a/gm/imagefiltersscaled.cpp

+++ b/gm/imagefiltersscaled.cpp

@@ -16,6 +16,7 @@

#include "SkMorphologyImageFilter.h"

#include "SkOffsetImageFilter.h"

#include "SkPerlinNoiseShader.h"

+#include "SkPoint3.h"

#include "SkRectShaderImageFilter.h"

#include "SkScalar.h"

#include "gm.h"

@@ -75,9 +76,11 @@ protected:

SkAutoTUnref<SkShader> noise(SkPerlinNoiseShader::CreateFractalNoise(

SkDoubleToScalar(0.1), SkDoubleToScalar(0.05), 1, 0));

- SkPoint3 pointLocation(0, 0, SkIntToScalar(10));

- SkPoint3 spotLocation(SkIntToScalar(-10), SkIntToScalar(-10), SkIntToScalar(20));

- SkPoint3 spotTarget(SkIntToScalar(40), SkIntToScalar(40), 0);

+ SkPoint3 pointLocation = SkPoint3::Make(0, 0, SkIntToScalar(10));

+ SkPoint3 spotLocation = SkPoint3::Make(SkIntToScalar(-10),

+ SkIntToScalar(-10),

+ SkIntToScalar(20));

+ SkPoint3 spotTarget = SkPoint3::Make(SkIntToScalar(40), SkIntToScalar(40), 0);

SkScalar spotExponent = SK_Scalar1;

SkScalar cutoffAngle = SkIntToScalar(15);

SkScalar kd = SkIntToScalar(2);