Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Side by Side Diff: src/x64/debug-x64.cc

Issue 1229673005: Debugger: record reloc info for debug break slot immediate before the slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/debug-mips64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 138
139 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 139 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
140 // Register state just before return from JS function (from codegen-x64.cc). 140 // Register state just before return from JS function (from codegen-x64.cc).
141 // ----------- S t a t e ------------- 141 // ----------- S t a t e -------------
142 // -- rax: return value 142 // -- rax: return value
143 // ----------------------------------- 143 // -----------------------------------
144 Generate_DebugBreakCallHelper(masm, rax.bit()); 144 Generate_DebugBreakCallHelper(masm, rax.bit());
145 } 145 }
146 146
147 147
148 void DebugCodegen::GenerateSlot(MacroAssembler* masm) { 148 void DebugCodegen::GenerateSlot(MacroAssembler* masm,
149 DebugCodegen::SlotLocation location,
150 int call_argc) {
149 // Generate enough nop's to make space for a call instruction. 151 // Generate enough nop's to make space for a call instruction.
150 Label check_codesize; 152 Label check_codesize;
151 __ bind(&check_codesize); 153 __ bind(&check_codesize);
154 RecordRelocInfo(masm, location, call_argc);
152 __ Nop(Assembler::kDebugBreakSlotLength); 155 __ Nop(Assembler::kDebugBreakSlotLength);
153 DCHECK_EQ(Assembler::kDebugBreakSlotLength, 156 DCHECK_EQ(Assembler::kDebugBreakSlotLength,
154 masm->SizeOfCodeGeneratedSince(&check_codesize)); 157 masm->SizeOfCodeGeneratedSince(&check_codesize));
155 } 158 }
156 159
157 160
158 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) { 161 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) {
159 // In the places where a debug break slot is inserted no registers can contain 162 // In the places where a debug break slot is inserted no registers can contain
160 // object pointers. 163 // object pointers.
161 Generate_DebugBreakCallHelper(masm, 0); 164 Generate_DebugBreakCallHelper(masm, 0);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 } 196 }
194 197
195 const bool LiveEdit::kFrameDropperSupported = true; 198 const bool LiveEdit::kFrameDropperSupported = true;
196 199
197 #undef __ 200 #undef __
198 201
199 } // namespace internal 202 } // namespace internal
200 } // namespace v8 203 } // namespace v8
201 204
202 #endif // V8_TARGET_ARCH_X64 205 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips64/debug-mips64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698