Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/mips64/debug-mips64.cc

Issue 1229673005: Debugger: record reloc info for debug break slot immediate before the slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/debug-mips.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_MIPS64 9 #if V8_TARGET_ARCH_MIPS64
10 10
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 133
134 134
135 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 135 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
136 // In places other than IC call sites it is expected that v0 is TOS which 136 // In places other than IC call sites it is expected that v0 is TOS which
137 // is an object - this is not generally the case so this should be used with 137 // is an object - this is not generally the case so this should be used with
138 // care. 138 // care.
139 Generate_DebugBreakCallHelper(masm, v0.bit()); 139 Generate_DebugBreakCallHelper(masm, v0.bit());
140 } 140 }
141 141
142 142
143 void DebugCodegen::GenerateSlot(MacroAssembler* masm) { 143 void DebugCodegen::GenerateSlot(MacroAssembler* masm,
144 DebugCodegen::SlotLocation location,
145 int call_argc) {
144 // Generate enough nop's to make space for a call instruction. Avoid emitting 146 // Generate enough nop's to make space for a call instruction. Avoid emitting
145 // the trampoline pool in the debug break slot code. 147 // the trampoline pool in the debug break slot code.
146 Assembler::BlockTrampolinePoolScope block_trampoline_pool(masm); 148 Assembler::BlockTrampolinePoolScope block_trampoline_pool(masm);
147 Label check_codesize; 149 Label check_codesize;
148 __ bind(&check_codesize); 150 __ bind(&check_codesize);
151 RecordRelocInfo(masm, location, call_argc);
149 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) { 152 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) {
150 __ nop(MacroAssembler::DEBUG_BREAK_NOP); 153 __ nop(MacroAssembler::DEBUG_BREAK_NOP);
151 } 154 }
152 DCHECK_EQ(Assembler::kDebugBreakSlotInstructions, 155 DCHECK_EQ(Assembler::kDebugBreakSlotInstructions,
153 masm->InstructionsGeneratedSince(&check_codesize)); 156 masm->InstructionsGeneratedSince(&check_codesize));
154 } 157 }
155 158
156 159
157 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) { 160 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) {
158 // In the places where a debug break slot is inserted no registers can contain 161 // In the places where a debug break slot is inserted no registers can contain
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 195
193 196
194 const bool LiveEdit::kFrameDropperSupported = true; 197 const bool LiveEdit::kFrameDropperSupported = true;
195 198
196 #undef __ 199 #undef __
197 200
198 } // namespace internal 201 } // namespace internal
199 } // namespace v8 202 } // namespace v8
200 203
201 #endif // V8_TARGET_ARCH_MIPS64 204 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/debug-mips.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698